[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] acinclude.m4.in
From:       Stephan Kulow <coolo () kde ! org>
Date:       2000-10-10 10:21:38
[Download RAW message or body]

Michael Matz wrote:
> 
> Hi,
> 
> On Tue, 10 Oct 2000, Stephan Kulow wrote:
> > > This fixes the DPMS test (the dpms.h uses CARD16, which is defined in
> > > Xmd.h, included by Xproto.h, which wasn't included by the test, making it
> > > fail every time), and includes that -fno-rtti checking, so users can't
> > > give that anymore in CXX or CXXFLAGS (they can later by patching the
> > > Makefiles or using magical things like AM_CXXFLAGS, but anyway ;))
> > >
> > > No, it's not a showstopper.
> > Well, I would say it's one as there are still rumours that compiling
> > KDE with -fno-rtti is the ultimate speed boast - and causes crashes
> >
> > And the patch looks cool (especially your variable names :), but I
> 
> I like __underscores__ ;)
> 
> > would like to know why you use IFS="     ". I thought it can only be
> > one character.
> 
> Nope. IFS can be any character combination. All characters in it are used
> by the shell to split a string into multiple values, and only the first
> character is used, when synthesizing a string out of multiple values (like
> what $* does). (Btw. just in case your mail reader was confused, the above
> was IFS="<space><tab>")

Then I don't understand why you set it at all, as man bash says:
The default value is ``<space><tab><newline>'' - the newline shouldn't
mater when looking at CXX :)

Anyway - commit asap

Greetings, Stephan

-- 
... but you ain't had mine

[prev in list] [next in list] [prev in thread] [next in thread]