[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Problems in KIO
From:       Antonio Larrosa <antlarr () arrakis ! es>
Date:       2000-10-09 22:26:25
[Download RAW message or body]

David Faure wrote:
> 
> On Mon, 09 Oct 2000, Antonio Larrosa wrote :
> >Hi,
> >
> >I've noticed something which is (at least) very weird.
> >
> >Try copying a big file from a slow source (I tried a 5 Mb. file from a
> >CDRom) while the file is being copied, move the mouse over the icon
> >(that is shown before the file has been completely copied). The status
> >bar reports the file is x Kb (where x is less than 5Mb, as it has
> >not finished copying it).
> >
> >When the file has been copied, move the mouse over the icon. Konqueror
> >says the file is x Kb. but the file is in fact 5Mb long. The Properties
> >dialog also says the file is x Mb. long.
> >
> >I think this should be fixed before 2.0, as it took me a while to
> >realize that the file was correctly copied, and it wasn't truncated
> >as it seemed to be.
> >
> >It seems that it would be good to add a call
> >KDirWatch::self()->setFileDirty
> >somewhere on KIO for each file after it's copied (or for a list of files
> >after they're all copied).
> >
> >I suppose it would add an overhead to each copied/moved file, but I
> >don't know of a better solution.
> >
> >Any ideas ?
> 
> This is already done : CopyJob does a
>         allDirNotify.FilesAdded( url );
> which should make all konqueror viewing that url (it's the directory) reload the directory.
> It's a lot better than setFileDirty (which I marked as deprecated BTW), because
> it's network transparent, and it notifies all konqueror windows (not just the one where the copy
> happened).
> 
> Ah - I know. What happens next is that the KDirLister does an "update" on the directory,
> i.e. it lists it again and compares with its current listing, handling "new" and "deleted" files.
> What's missing is "changed" files......
> 
> We need a method that compares two KFileItems
> (otherwise we would have to duplicate the code in kfileitem's constructor, to read
> the udsentry, that's why I suggest to create a KFileItem with the new item).
> 
> Ok, I'll do that tomorrow unless you want to have a go at it.
> 


If you want to do it, just do it. If you have more important things to
fix,
then tell me and I'll give it a try (now that you've told me where the
problem is
exactly and how to fix it :) ).

Greetings,

--
Antonio Larrosa Jimenez
KDE core developer
antlarr@arrakis.es        larrosa@kde.org
http://www.arrakis.es/~rlarrosa
KDE - The development framework of the future, today.

[prev in list] [next in list] [prev in thread] [next in thread]