[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    PATCH: artsdsp (needs testing)
From:       Stefan Westerfeld <stefan () space ! twc ! de>
Date:       2000-10-06 13:07:49
[Download RAW message or body]

Hi!

Under linux, libpthread seems to have a kind of all-or-nothing behaviour.
Either you link against it, or you don't. If you don't link your app against
it, and dynamically load other parts that do, then you'll see random segfaults.

As exactly this "mixing" behaviour can happen with the current libartsc,
here is a patch which links libartsc against libpthread.  On my system, 
this fixes artsdsp and make it work great with all kinds of apps again.
Without the patch, mpg123 for instance recently suffered crashes when
used with artsdsp.

Please, if you have the time, give artsdsp a good test, as soon as you

- updated your CVS (at least kdelibs/arts)
- applied the attached patch
- disabled "X11 server for exchanging security infos" in kcontrol

   Cu... Stefan
-- 
  -* Stefan Westerfeld, stefan@space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         

["20001006-artsdsp.diff" (text/plain)]

Index: Makefile.am
===================================================================
RCS file: /home/kde/kdelibs/arts/artsc/Makefile.am,v
retrieving revision 1.6
diff -u -u -r1.6 Makefile.am
--- Makefile.am	2000/05/05 22:00:45	1.6
+++ Makefile.am	2000/10/06 12:11:30
@@ -14,7 +14,7 @@
 
 libartsc_la_SOURCES = artsc.c
 libartsc_la_LDFLAGS = -no-undefined
-libartsc_la_LIBADD = $(top_builddir)/libltdl/libltdlc.la
+libartsc_la_LIBADD = $(top_builddir)/libltdl/libltdlc.la $(LIBPTHREAD) $(USE_THREADS)
 
 libartscbackend_la_SOURCES = artscbackend.cc
 libartscbackend_la_LDFLAGS = -no-undefined -module
Index: artsc-config.in
===================================================================
RCS file: /home/kde/kdelibs/arts/artsc/artsc-config.in,v
retrieving revision 1.4
diff -u -u -r1.4 artsc-config.in
--- artsc-config.in	2000/07/06 17:40:23	1.4
+++ artsc-config.in	2000/10/06 12:11:30
@@ -25,7 +25,7 @@
 do
   case $1 in
     --libs)
-	  flags="$flags -L$libdir $libdl -lartsc"
+	  flags="$flags -L$libdir $libdl -lartsc @USE_THREADS@ @LIBPTHREAD@"
 	  ;;
     --cflags)
 	  flags="$flags -I$includedir/artsc"


[prev in list] [next in list] [prev in thread] [next in thread]