[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdesktop (Re: New default Kwin style)
From:       Antonio Larrosa <antlarr () arrakis ! es>
Date:       2000-10-03 17:31:51
[Download RAW message or body]

David Faure wrote:
> 
> >Yes indeed.
> >But this is a KIconDialog / KInstance bug (not really kdesktop itself).
> >


Aargh, I was looking for this bug, but didn't find that. Nice one btw 
thanks for having a look :)

> >Here is the guilty code for this :
> >void KInstance::newIconLoader() const
> >{
> >    delete _iconLoader;
> >    KIconTheme::reconfigure();
> >    _iconLoader = 0;
> >}
> >
> >So anyone that was keeping a pointer to the iconloader now points to
> >a deleted object. Since KIconDialog keeps a pointer to the iconloader
> >(instead of asking KGlobal each time), crash.
> >
> >I'm not sure which one is guilty, in fact - this could be fixed at both ends,
> >but generally deleting a pointer from KGlobal seems a bad idea to me,
> >so I'd rather advocate fixing KInstance::newIconLoader so that it reconfigures
> >the iconloader instead of deleting it.
> 
> The attached patch fixes this crash for me.
> 
> Comments / permission for committing ?
> 

Please, do so.

--
Antonio Larrosa Jimenez
KDE Core developer
antonio@larrosa.org        larrosa@kde.org
http://www.larrosa.org
KDE - The development framework of the future, today.

[prev in list] [next in list] [prev in thread] [next in thread]