From kde-core-devel Thu Sep 28 11:55:20 2000 From: Michael Matz Date: Thu, 28 Sep 2000 11:55:20 +0000 To: kde-core-devel Subject: Re: konsole w/ --enable-final X-MARC-Message: https://marc.info/?l=kde-core-devel&m=97014203918724 Hi, On Wed, 27 Sep 2000, Lars Doelle wrote: > On Tue, 26 Sep 2000, Werner Trobin wrote: > > Currently konsole breaks with --enable-final because > > TEPty.C #defines _XOPEN_SOURCE (for grantpt() and Cie.) > > before #including stdlib.h. > > Of course there are other places (before) where this > > file is included and therefore defining that symbol in > > this file doesn't really help ;) What a include crap ;( For an immediate solution we could reorder the files in Makefile.am. (Ohh, I've just seen, that this was done. OK.) > > My "fix" would be to copy this #if foo #define stuff > > to every place stdlib gets included, but I'm sure > > there's a better solution. No. This _XOPEN_SOURCE define isn't that good where it isn't needed. > stdlib.h is relativly strange with respect to the pty stuff. > > I can offer to remove _XOPEN_SOURCE and put the three function headers in > literally, which would be ok, since they are protected by configure. I'd be > more happy if there'd be any other solution. As said, as konsole is a special case, we can live with the reordering. Ciao, Michael.