[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    RE: PATCH: added showDocument in kjava to fix java menus
From:       Dima Rogozin <drogozin () qed ! com>
Date:       2000-09-27 13:37:50
[Download RAW message or body]


The only problem I see with the patch is that it exposes a lot of KJava
internals
into khtml_part. 

Last weekend I tried to do exactly the same. The thing which stopped me
was a trick
in Console code Stephan uses. The original output stream is saved and
used later.
It never worked for me on JDK SUN 1.2.2.
Stephan, could you test it?

In my patch I have created showDocument() and showStatus() signals for
KJavaAppletWidget()
and connected to them in rendering_applet.cpp. Since this object knows
about khtml_part there are no changes in khtml_part code.

I believe khtml_part should be left unchanged. In the future we need to
replace the whole kjava library with standard Java PlugIn. It will fix
all Java problem at once including https support. Keep thin in mind when
you do the patch.

Regards,
Dima.
 







 

-----Original Message-----
From: Lars Knoll [mailto:lars@trolltech.com]
Sent: Wednesday, September 27, 2000 6:34 AM
To: kde-core-devel@max.tat.physik.uni-tuebingen.de
Subject: Re: PATCH: added showDocument in kjava to fix java menus


On Wed, 27 Sep 2000, Matthias Hoelzer-Kluepfel wrote:
> On Tue, 26 Sep 2000, Stefan Schimanski wrote:
> > > Hi,
> >
> > I've added implementations for the showDocument and showStatus calls to
> > kjas for java applets that want to change the location of a frame. This
> > should fix java menus.
>
> Wow, great! Please apply. But I can't say I was able to review the patch
> ...

/me didn't get the patch, so I can't review it... Stefan could you send
it to 
me in private mail please?

Lars

[prev in list] [next in list] [prev in thread] [next in thread]