From kde-core-devel Fri Sep 01 20:30:55 2000 From: Antonio Larrosa Date: Fri, 01 Sep 2000 20:30:55 +0000 To: kde-core-devel Subject: Re: rfc: binary incompatible change X-MARC-Message: https://marc.info/?l=kde-core-devel&m=96784708716991 Harri Porten wrote: > > Simon Hausmann wrote: > > > > Hi, > > > > A few days ago I asked for comments for a binary incompatible change > > (http://lists.kde.org/?l=kde-core-devel&m=96749801432739&w=2) . Besides > > David obviously agreeing :-) I didn't read any comments. > > > > Is it really okay to commit? >;-) > > Does anybody have a good workaround for the problem? (a binary compatible one preferrably ;) > > If you do so I would like to sneak in a new virtual function for the > damn window.open() problem as well. It would also affect only Konqueror. > How about concentrating these on a fixed date ? > I have to do a change on libkmid. The fix for Bug#9171 (which is a showstopper bug for libkmid) included marking many virtual methods as obsolete (and remove these methods when binary incompatible changes are allowed). So you can guess that I'd like to remove these functions the same day than those bin incompat changes if you allow me to do so (I'll send the patch first to kde-multimedia for testing). This change only affects kmid on CVS. Now the question is, if we're going to break binary compatibility, shouldn't we look for all the things already marked as "obsolete" or "to be fixed when bin. incompat. changes are allowed again" and clean them ? If we're really going to break it (not sure if we should), I think we should wait at least a week for the last binary incompatible day, so that people can prepare their patches and test them. Greetings, -- Antonio Larrosa Jimenez KDE Core developer antonio@larrosa.org larrosa@kde.org http://www.larrosa.org KDE - The development framework of the future, today.