[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: patch: kurl
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2000-08-29 22:04:10
[Download RAW message or body]

On Tue, 29 Aug 2000, David Faure wrote:
> At 15:29 28/08/00 -0700, you wrote:
> >On Mon, 28 Aug 2000, Oliver Henning wrote:
> >> > I think it gives a false hit for /blah/foo and /blah/foo2/test.
> >> > And what about /blah/foo/ and /blah/foo/test?
> >>
> >> Agreed.
> >>
> >> > Hm.. it seems cleanDirPath strips the leading '/' that KURL::path(1) had
> >> > so carefully added. What about the attached patch then.
> >>
> >> I think this one gives a false hit on /blah/foo and /blah/foo.
> >
> >kurltest.cpp says that it should give a hit in that case.
> >  
> >And according to the comment in kurl.h this is intented:
> >
> > * @return true if this url is a parent of @p u (or the same URL as @p u)     
> 
> Yes, so that if you get a notification that u1 was changed, and you're
> watching for anything under u2 (e.g. bookmarks, etc.), then you're interested
> in the event if u2.isParentOf(u1). As I said when writing isParentOf,
> I couldn't find a better name :)

Probably offtopic but how about a "supersetOf" and "subsetOf" or are they more
confusing ??

Regards,
Dawit A. 

[prev in list] [next in list] [prev in thread] [next in thread]