[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: KFileDialog focus problem
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! TU-Berlin ! DE>
Date:       2000-08-26 9:49:47
[Download RAW message or body]

On Sat, Aug 26, 2000 at 12:09:55AM -0700, Waldo Bastian wrote:

Hi,

> > > The following patch fixes a focus problem of the file dialog.

wow, thanks for figuring this out! 
 
> The actual cause of the problem seems to be kdialog.cpp:31
> 
> KDialog::KDialog(QWidget *parent, const char *name, bool modal, WFlags f)
>   : QDialog(parent, name, modal, f)
> {
>   setFocusPolicy(QWidget::StrongFocus);
> }                                                                             
> 
> I have a very poor understanding of this whole focus stuff but this looks 
> plain wrong.

yeah, I agree. A dialog itself should never accept focus -- its contained
widgets probably, but not the dialog.

Cheers,
Carsten Pfeiffer
-- 
http://www.geocities.com/SiliconValley/1632/

[prev in list] [next in list] [prev in thread] [next in thread]