[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: ktoolbarbutton patch
From:       Reginald Stadlbauer <reggie () trolltech ! com>
Date:       2000-08-16 18:59:23
[Download RAW message or body]

On Wed, 16 Aug 2000, David Faure wrote:
> On Wed, 16 Aug 2000, Werner Trobin wrote :
> >On Wed, 16 Aug 2000, Reginald Stadlbauer wrote:
> >> Hi!
> >> IN KPresenter and in some other places, sometimes the pixmaps of
> >> KToolBarButtons disappeared, when changing the text of the action. I
> >> couldn't really figure out the problem, but following patch seems to fix
> >> it. Can I commit?
> >>
> >> [reggie@piefke kdeui]$ cvs -z9 diff
> >> cvs -z9 comcvs server: Diffing .
> >> Index: ktoolbarbutton.cpp
> >> ===================================================================
> >> RCS file: /home/kde/kdelibs/kdeui/ktoolbarbutton.cpp,v
> >> retrieving revision 1.32
> >> diff -u -r1.32 ktoolbarbutton.cpp
> >> --- ktoolbarbutton.cpp  2000/07/12 17:50:35     1.32
> >> +++ ktoolbarbutton.cpp  2000/08/16 18:37:51
> >> @@ -275,8 +275,9 @@
> >>  void KToolBarButton::setText( const QString& text)
> >>  {
> >>    d->setText(text);
> >> -  repaint (false);
> >>    QButton::setText( text );
> >> +  QButton::setPixmap( isEnabled() ? defaultPixmap : disabledPixmap );
> >> +  repaint (false);
> >>  }
> >
> >Yessss - *please* do so - this bug is really annoying :)))
>
> Yes, OTOH it looks like the wrong fix to me (setText shouldn't change the
> pixmap, right ?) but if even you don't know where the bug really comes
> from, then there's no other solution... :-)

Well, it just sets the current pixmap again. Something really goes wrong in 
KToolBarButton sometimes - remember that also the ::text() functions returns 
very often an empty string although there is a text set. This one we still 
couldn't fix AFAIK.

-- 
Reggie (reggie@trolltech.com)

[prev in list] [next in list] [prev in thread] [next in thread]