[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KAboutDialog and KHexEdit
From:       Espen Sand <espen.sand () neo ! no>
Date:       2000-07-24 13:12:36
[Download RAW message or body]

On Mon, 24 Jul 2000, Richard Moore wrote:
> Espen Sand wrote:
> > 
> > At 10:48 PM 7/23/00 +0100, you wrote:
> > >Why does khexedit's about dialog include kaboutdialog_private.h?
> > >Surely this defeats the point of a private header file.
> > 
> > I never did this :) . The KAboutDialog class code was changed a few
> > months back when someone (I don't remember who at the momemt)
> > transformed the code into the private stuff. That is ok, expect for
> > that I did not intend the code (or at least not all that has been moved)
> > in the KAboutDialog to be private when I made it. The reason was that I
> > wanted it to be possible to make dialogs like the one I made in KHexEdit
> 
> Do you think you could have a look at keystone's about dialog? it
> is completely based on that of khexedit, but it doesn't work properly
> - most of the widgets and text are missing. I really can't see what
> is wrong.

Will do that in a few days (cc'ing to myself so that I don't forget it :)

> 
> > 
> > I had forgot these changes. Should we revert the changes now or
> > after 2.0? I think it is the KAboutContainerBase that needs to be
> > moved back.
> 
> I would say it is safe to fix as it is a serious error to require
> people to use the _private header.

I agree.


-- 
Espen Sand

[prev in list] [next in list] [prev in thread] [next in thread]