[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Shouldn't KSplitList get its own source/header files ?
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-06-25 13:10:46
[Download RAW message or body]

On Sat, Jun 24, 2000 at 02:55:19PM -0400, Dawit Alemayehu wrote:
> On Sat, 24 Jun 2000, David Faure wrote:
> > On Sat, Jun 24, 2000 at 02:23:56PM -0400, Dawit Alemayehu wrote:
> > > Hello,
> > > 
> > > I was working on the cookies dialog when I run into this. KSplitList and
> > > KSplitListItem are currently defined in the same source/header file as the
> > > KKeyDialog class.  However, KSplitList is used by classes other than
> > > KKeyDialog though it it might have been initially designed for use in KKeyDialog.
> > > The question is that can I break this class out into its own header/source
> > > files or is this done on purpose ?  This will not break any exisiting code as
> > > the new header, kspiltlist.h, will be included in kkeydialog.h ...
> > 
> > Hmm, I have found that this widget is full of bugs. At least in KKeyDialog,
> > when you resize the dialog the contents is not redrawn and changing the
> > current item redraws the item with the new width (-> very buggy effect).
> > Also, it splits at 50% which is not always wanted (it would be better if it
> > found where to split according to the contents).
> 
> I know.  This happens in the cookies dialog as well...  
> 
> > What's the reason for not using QListView ?
> 
> Nothing :))  It was just what I found the kcookiespolicies.  I guess I can
> switch it over.  Does this mean it should stay where it is ?

In my very humble opinion, it should be completely removed and both dialogs
should use a working and maintained widget, QListView.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]