[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: konqui's fileview  view-modes
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-06-03 16:41:21
[Download RAW message or body]

On Sat, Jun 03, 2000 at 03:21:23PM +0200, Simon Hausmann wrote:
> 
> 
> On Sat, 3 Jun 2000 tibirna@kde.org wrote:
> 
> > Hello
> > 
> > Konqueror considers changes from a view-mode to another (e.g. icon-view to
> > detailed-view and such) as part of the browsing history. Hitting back
> > action after a view mode change brings back the old mode. Is this
> > intended? Is this known? Thanks
> 
> I agree, IMHO changing the viewmode via the menu shouldn't affect the
> history.
> 
> This patch fixes it:
> 
> Index: konq_mainwindow.cc
> ===================================================================
> RCS file: /home/kde/kdebase/konqueror/konq_mainwindow.cc,v
> retrieving revision 1.560
> diff -u -b -r1.560 konq_mainwindow.cc
> --- konq_mainwindow.cc	2000/06/03 01:59:43	1.560
> +++ konq_mainwindow.cc	2000/06/03 13:17:04
> @@ -517,6 +517,7 @@
>    if ( m_currentView->service()->name() == modeName )
>      return;
>  
> +  m_currentView->lockHistory();
>    m_currentView->changeViewMode( m_currentView->serviceType(), modeName,
>                                   m_currentView->url() );
>  
> 
> David -- ok to apply?

Yes, ok.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]