[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Binary incompatible change to KJanusWidget
From:       Espen Sand <espensa () online ! no>
Date:       2000-06-02 15:04:12
[Download RAW message or body]

On Fri, 02 Jun 2000, Matthias Kalle Dalheimer wrote:
> Hi,
> 
> since the libraries are currently open for binary-incompatible changes:
> 
> Are there any objections against the following change:
> 
> - Make the add*Page() methods in KJanusWidget virtual.
> - For each method in add*Page() do; add an overloaded method that has a
> QStringList as its second parameter instead of a const QString&.

Fine with me.

> 
> The first one is a general one - there are many possible ways you might
> want to extend the addPage functionality in an application. In fact, it
> would be good if we went through all of the kdelibs and checked for
> methods that better be virtual. But I doubt that anybody now has the
> time (or the interest) to do that.
> 
> The second one is needed in order to make KJanusWidget support
> hierarchies. You can make it display a listview currently, but with all
> items at one level - then you don't win much by using a listview after
> all. This change is also a necessary (but not sufficient) condition for
> making KControl use KJanusWidget in the future.

This is (somewhere) on my todo. I have not had time to do it yet.

-- 
Espen Sand

[prev in list] [next in list] [prev in thread] [next in thread]