[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: IMPORTANT REMINDER: no more binary incompatible changes after tomorrow
From:       Waldo Bastian <bastian () kde ! org>
Date:       2000-05-31 5:57:32
[Download RAW message or body]

On Tue, 30 May 2000, Alexei Dets wrote:
> Hi!
>
> Kurt Granroth wrote:
> > Alexei Dets wrote:
> > > Kurt Granroth wrote:
> > > > Tomorrow is the *LAST* time we will have to add binary incompatible
> > > > changes to kdelibs.  This is because 1.91 (Kleopatra) will be coming
> > > > out the following Wednesday.  And, from the release schedule:
> > >
> > > At least KURL needs to be fixed! And KProcess too. They don't work
> > > correctly with non-ascii paths and arguments. In fact they don't
> > > work at all in this case!!! I'm 99% sure that this will require
> > > binary (and may be even source) incompatible changes. And such
> > > important thing can't be done in one day :-(
> >
> > What binary incompatible API changes are necessary?
>
> At least KURL constructor & its decode + encode methods must be changed
> to accept third optional parameter - encoding (charset) of URL. But I don't
> know what type must be used for this parameter better - const char*, const
> QString&, QTextCodec& or something else? What is the preffered KDE way to
> pass such things?

I have added an extra 'int'. I guess/hope we can use this to identify the 
charset by using its 'MIBenum' (See QtextCodec::mibEnum())

I just commited it to CVS.

Cheers,
Waldo

[prev in list] [next in list] [prev in thread] [next in thread]