[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Bug#3864: bug report dialog dissapears when changing desktops
From:       Espen Sand <espen.sand () neo ! no>
Date:       2000-05-22 6:52:41
[Download RAW message or body]

On Mon, 22 May 2000, Waldo Bastian wrote:
>KDialogBase used to emit "hidden" whenever it got a QHideEvent. A QHideEvent 
>is generated whenever the dialog closes _OR_ when you switch to another 
>desktop/minimize the dialog.
>
>I have changed KDialogBase to only emit hidden when the dialog closes/ is 
>hidden by the program. Not when you switch desktops or minimize the dialog.
>
>This makes the "hidden" signal usable as a general purpose "dialog is 
>finished" signal. (KAboutDialog and friends already used it as such)
>
>Note that this change breaks all dialogs which need the "hidden" signal when 
>the dialog becomes minimized. I am not aware of any such dialogs though.

Hi, 

I got aware of this problem a few days ago. Nice that it has been fixed. Note
that the in KDialogBase::closeEvent() I do a cancel/close pushbutton animation
if  possible. The closeEvent will be triggered if one press the WM "x" button
so the docs in the header file for KDialogBase::hidden() is not quite 
correct when it say:

"This signal is _NOT_ emitted when the window manager hides the dialog."

or atleast it can be confusing.

If one press the "x" button (or the "Close" entry in the menu) in the WM, the
cancel/close button will be automatically pressed which again will fake a
button click which causes the hidden signal to be emitted.


I'll update the docs for this one I know how to explain this in a simple 
manner :)


-- 
Espen Sand

[prev in list] [next in list] [prev in thread] [next in thread]