[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    kdirwatch (Was: kdelibs/kio)
From:       Waldo Bastian <bastian () kde ! org>
Date:       2000-05-04 4:42:49
[Download RAW message or body]

On Wed, 03 May 2000, CVS by granroth wrote:
> kdelibs/kio kdirwatch.cpp,1.21,1.22 kdirwatch.h,1.11,1.12
> Author: granroth
> CVSROOT: /home/kde
> Thu May  4 01:28:59 MET DST 2000
> Update of /home/kde/kdelibs/kio
> In directory zeus:/tmp/cvs-serv23412
>
> Modified Files:
> 	kdirwatch.cpp kdirwatch.h
> Log Message:
> Moved the #include <config.h> line from kdirwatch.h to kdirwatch.cpp.  This
> means that if you are using kdirwatch and you want FAM in your app, you'll
> have to make sure that you include config.h before kdirwatch.h

Ehm.

> This is necessary, though.  Keeping the config.h reference in the header
> file meant that all apps that used kdirwatch (bascially any app that uses
> kfile!) *need* to have a config.h file... this is fine for autoconf apps,
> but not so good for apps with custom makefiles.

Your observation is correct but your solution only partly. The right thing to 
do is to hide all the implementation details in a private class via the 
famous d-pointer. Then the application doesn't need to know about FAM at all.

I will change this, however, this change will be binary incompatible.

Cheers,
Waldo

[prev in list] [next in list] [prev in thread] [next in thread]