[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Please verify patch (BR #2202)
From:       Michael Matz <matz () ifh ! de>
Date:       2000-04-16 22:33:47
[Download RAW message or body]

Hi,

On Sun, 16 Apr 2000, Hans Petter Bieker wrote:
> > Could people have a look at the following patch and make sure that it doesn't 
> > break anything on there particular OS. (I remember Caldera having some issues 
> >  
> > -#if defined(Lynx) || defined(SCO) && !defined(SCO_USA)
> > +#if defined(Lynx) || defined(SCO) && !defined(SCO_USA) || 
> > !defined(HAVE_CRYPT_H)
> >  char *crypt(const char *s1, const char *s2)
> >  {
> >         return(s2);     
> 
> AFAIK FreeBSD (or BSD in general) doesn't have crypt.h, but it has
> crypt().

Also old linuxes have it in unistd.h. And the prototype doesn't match the
one here given (that was the actual bug report about).

> I guess the right thing to do here would be to add a test for crypt().

And get rid of the fake crypt() alltogether, and only call crypt() in
verify.c and kdmshutdown.cpp, if it exists.

Thanks to KDE_MISC_TESTS we already have a test for crypt() (HAVE_CRYPT),
and the library where it is in. Kdm is really old stuff, and doesn't use
it yet.


Ciao,
Michael.

[prev in list] [next in list] [prev in thread] [next in thread]