[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] faster Makefile.in -> Makefile translation
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-04-03 14:05:01
[Download RAW message or body]

Woohoo ! Real nice.
Works great here.
A few comments:
* --enable-fast-perl      enable fast Makefile generation (needs perl)
  I guess the help line should be changed to --disable-fast-perl, if it's
  enabled by default.

* Instead of 
+  cat $CONFIG_STATUS | perl $ac_aux_dir/conf.change.pl "$ac_aux_dir" > config.s
tatus.new\
+  rm -f $CONFIG_STATUS\
+  mv config.status.new $CONFIG_STATUS\

why not simply use perl -i ? This would make all that in one line, although
this prevents passing ac_aux_dir as argument. What about:
perl -i $ac_aux_dir/conf.change.pl $CONFIG_STATUS
and the perl script uses $0 to figure out $ac_aux_dir ?

This reduces config.sed to 4 lines, which perhaps makes it possible to 
bundle it within Makefile.common

I love it too !

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]