[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] faster Makefile.in -> Makefile translation
From:       Michael Matz <matz () ifh ! de>
Date:       2000-04-02 17:12:45
[Download RAW message or body]

Hi,

On Sun, 2 Apr 2000, Stephan Kulow wrote:
> > Hehe. Only problem I see is, that I had nearly to copy the whole AC_OUTPUT
> > and AC_OUTPUT_FILES functions from autoconf. For what I wanted to do, it
> > isn't modular enough. So if a new autoconf version springs into existence
> > I have to review these functions.
> > 

> That's the problem left. acinclude.m4.in is currently licensed LGPL,
> so we can't simply put autoconf macros there. We could think of

Put them into another file?

> relicensing, but I first want to work on different solutions to get
> our KDE_OUTPUT working.

Hmm. I first tried hard, to make KDE_OUTPUT to only use self written code.
The problem is that AC_OUTPUT is really involved and does many funny
things. If one wants to mimic this behaviour _and_ wants to change it only
a little bit there is no other solution than to copy AC_OUTPUT and friends
and change this copy.

> After all _requiring_ perl isn't that a bad option - the FSF doesn't
> want to require perl as it's not their code, but that doesn't need to
> hinder KDE.

OK, then we could kill most of the code dealing with the normal sed
substitutions. But then perl would also be required by all people
compiling from source. I don't think that would be a real problem, but I
first thought that it would be a good idea, to have an option to fallback
to normal configure behaviour.

I'm willing to work on a KDE specific solution, which does not use any sed
(right now config.h is created the old way), but requires perl.

Meanwhile there has popped up a problem with srcdir==builddir (who is
using that? ;) ). The VPATH substitution does not work in this case.
Quick fix is in attachment.


Ciao,
Michael.

["acinclude.m4.in.diff" (TEXT/PLAIN)]

--- acinclude.m4.in.orig	Sat Apr  1 22:42:24 2000
+++ acinclude.m4.in	Sun Apr  2 18:52:03 2000
@@ -3373,7 +3373,7 @@
 # If there is a colon in the path, we need to keep it.
 if test "x$srcdir" = x.; then
 changequote(, )dnl
-  ac_vpsub='/^[ 	]*VPATH[ 	]*=[^:]*$/d'
+  ac_vpsub='s/^[ 	]*VPATH[ 	]*=[^:]*$//g'
 changequote([, ])dnl
 fi
 


[prev in list] [next in list] [prev in thread] [next in thread]