[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KCrash + kapp changes
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-03-30 23:43:31
[Download RAW message or body]

On Fri, Mar 31, 2000 at 01:36:00AM +0200, Carsten Pfeiffer wrote:
> Hi,
> 
> Tom Braun had a look at the kcrash stuff and hacked a little bit on it.
> Changes:
> 
> - now a C++ class
> - less variables
> - easier interface
> - documentation
> - less bugs ;)
> 
> While doing this, some problem in kapp was discovered.
> parseCommandLine() was overloaded, one using KCmdLineArgs, the other one
> just parsing argv. This led to unnecessary and buggy code (one was being
> updated, the other not). Creating a KCmdLineArgs object and then using the
> first parseCommandLine() fixes this.
> 
> Anyone having objections to me committing?

The KCrash patch looks very good to me.
But the KCmdLineArgs one, unless you're sure about it, requires Waldo's input
I think (I'm surprised by the patch and by the "A KDE Application" false
data hack....)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]