[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Uhh setcrashhandler?
From:       Bernhard Rosenkraenzer <bero () redhat ! de>
Date:       2000-03-28 9:31:16
[Download RAW message or body]

On Tue, 28 Mar 2000, Dirk A. Mueller wrote:

> > #define KDE_CRASH_DEFAULT  ((void*)0x1000)
> > #define KDE_CRASH_INTERNAL ((void*)0x1001)
> > #define KDE_SAVE_NONE      ((void*)0x1002)
> 
> #defines?
> 
> in our header files?

We should definitely get rid of these particular ones (#defines as
function types are evil) - they break compilation on true ANSI compilers.
g++ 2.95.3 breaks at the emergencySaveFunction = KDE_SAVE_NONE; line in
kcrash.cpp, because ANSI C*+ forbids implicit conversion from "void *" in
assignments (and we can't cast to function types explicitly).

LLaP
bero

[prev in list] [next in list] [prev in thread] [next in thread]