[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Konqueror bug - can I fix???
From:       Robert Williams <rwilliams () jrc-utah ! com>
Date:       2000-01-28 21:05:36
[Download RAW message or body]

Simon Hausmann wrote:

> On Fri, 28 Jan 2000, David Faure wrote:
>
> > On Fri, Jan 28, 2000 at 12:29:55PM -0700, Robert Williams wrote:
> > > The bug:
> > >
> > > Open a text file (or any viewer) in konqueror and the location of the
> > > file stays in the title bar no matter what.  I can fix this but I am not
> > > sure where to start looking.  Is this in /libkonq?  or /konqueror?
> >
> > The title bar or the location bar, you mean ?
> >
> > I guess the location bar, no ?
> > I thought Simon fixed that...
>
> I thought so, too ;-)
>
> Well, I can't hack right now as I'm recompiling :(
>
> > Look in konq_mainview.cc, which holds the location bar.
>
> Yep.
> Robert, have a look at KonqMainView::openURL(), somewhere around line
> #328. I think the locationbar's text is set too "early" (as openView(),
> which is called in this case as the iconview provides the servicetype,
> might fail)). .. although openView() "resets" the locationbar text when it
> fails.
>
> I guess moving the setEditText() call into the "else" case ( just right
> before the KonqRun instance is allocated) , or even removing the call,
> should fix it.
>
> Ciao,
>  Simon

Sorry I meant the title bar...

Thanks David and Simon for the tips.  I want to get to know konqueror better to
help fix stuff like this.


--
Robert D. Williams       rwilliams@jrc-utah.com
Jarob Consulting         rwilliams@kde.org
Provo, Utah

[prev in list] [next in list] [prev in thread] [next in thread]