[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: BREAKAGE possible
From:       Kurt Granroth <granroth () kde ! org>
Date:       1999-12-28 20:24:35
[Download RAW message or body]

Stephan Kulow wrote:
> Kurt Granroth wrote:
> >   --- kstddirs.cpp      1999/12/14 10:19:52     1.83
> >   +++ kstddirs.cpp      1999/12/23 17:47:15
> >   @@ -507,7 +507,7 @@
> >        if (!strcmp(type, "config"))
> >       return "share/config/";
> >        if (!strcmp(type, "toolbar"))
> >   -     return "share/toolbar/";
> >   +     return "share/icons/";
> >        if (!strcmp(type, "apps"))
> >       return "share/applnk/";
> >        if (!strcmp(type, "sound"))
> No, if then remove "toolbar" completly.

I actually didn't change it at all, in the end.  This preserved all
"legacy" code for the moment.  After we get the new icons and put them
in the new places, we can re-evaluate this code.

[snip]
> Hmm, then we should get rid of loadIcon and rename
> loadApplicationIcon to it.  Otherwise loadIcon would crash. So
> remove loadIcon, port all uses to the new
> way and then rename loadApplicationIcon....

I'll look into that.

> > So now my questions:
> > 
> > 1) Am I forgetting something?  Will this horribly break something that
> >    I'm not aware of?  It seems to work for every case I've tested for
> >    so far.
> There is a lot of code out there using loadIcon, which would then access
> locate("toolbar", "filenew.png"). I would then favor to remove "toolbar"
> and the function loadIcon

Okay.  As it stands, loadApplicationIcon is THE "load icon" function
in KDE.  It will load any and all icons that you need.

I will investigate changing all apps to:

1) Use 'BarIcon' when they want a toolbar icon
and
2) Rename loadApplicationIcon to loadIcon and change all apps to use
   that.

> > 2) Is there a better way to move the icons then removing the current
> >    toolbar CVS module and re-importing it in the the new location?
> >    Coolo?
> No - the current icons have pratical no history anyway as they were
> renamed to .png

Cool.  As soon as I get the new icons, I'll do the move.
-- 
Kurt Granroth            | http://www.pobox.com/~kurt_granroth
KDE Developer/Evangelist | SuSE Labs Open Source Developer
granroth@kde.org         | granroth@suse.com
           KDE -- Putting a Friendly Face on Unix

[prev in list] [next in list] [prev in thread] [next in thread]