[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: keditctrl widget needs work!
From:       Don Sanders <dsanders () cch ! com ! au>
Date:       1999-10-20 12:13:15
[Download RAW message or body]

This is fantastic news, I really wanted this feature. 

I am willing to have a go at doing the clean up. I assume it's a few
hours laborious but fairly simple work.
 
Which version of QT do I need? I'm assuming I'll need the latest from CVS, and
the Oct 9 snapshot is out of date (which I just downloaded a few hours ago).

I assume I should just read the current kedit source code to generate an
exhaustive set of features (actually I would like to add shift-delete cut and
shift-insert pasting).

There are actually two keditctl cpp files in kdelibs/kdeui should I update
both, (there seems to be duplicated code there, keditcl1, keditcl2). I'm not to
sure what's the story there.

The other feature I want is undo/redo perhaps we can talk about this once I
have finished reimplementing the old functionality (I already have undo/redo
working in one app I have written, it uses a pretty general undo/redo class
based on the command and singletion design patterns, there doesn't seem to be
any infrastructure to support undo/redo in kdelibs,).

One final thing, I am working here under the assumption that you have added
proper word wrapping, rather than just the automatic line breaking that kedit
currently support (ie it distinguishes between hard and soft line breaks).

BFN,
Don.

BTW I have a ton of stuff to check in, is there any chance of you getting back
to me about the QListView licensing stuff? At least a stay alive message would
be nice.

On Wed, 20 Oct 1999, Matthias Ettrich wrote:
> Hi,
> 
> in libkdeui we have a keditctrl widget, which is basically an extremely hacky
> QMultiLineEdit subclass.
> 
> The purpose was to provide things like wordwrap and some more fancy commands
> like an emacs-like kill/yank system ( C-k  / C-y ).
> keditctrl is used in kedit (although I think kedit doubles the code, this has
> to be fixed as well) and for example in kmail.
> 
> It's however hacky and the wordwrap never worked in a really useful way, as all
> kmail users can testify.
> 
> I suggest keeping a keditctrl widget in the kdelibaries and to make kedit use
> it. BUT: the widget should be much much simpler as it is today. Most of the code
> can simply be removed, since QMultiLineEdit itself now supports wordwrap (in
> Qt-2.1).
> 
> I put that in, it wasn't fun at all (the datastructure isn't really suitable
> for word wrap), but it works now :-) Furthermore, we implemented different word
> wrap modi in QMultiLineEdit, so everything kedit supported can now be done with
> QMultiLineEdit, just better.
> 
> There are some features keditctrl should keep which are missing in
> QMultiLineEdit, for example that nifty c-k/c-y thing.
> 
> Anybody interested in doing this cleanup?
> 
> 
> Matthias

[prev in list] [next in list] [prev in thread] [next in thread]