[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    KDE_1_1_BRANCH: please review kbgndwm fix
From:       "Dirk A. Mueller" <dmuell () gmx ! net>
Date:       1999-09-04 11:41:24
[Download RAW message or body]

Hi,

please select kcontrol/desktop/background

- enable "Common background"
- select a wallpaper
- enable "Random"
- select Setup
- enable "pick files from directory"
- select a dir with lots of wallpapers (default is ok)
- select ok
- select "main" ok to apply the changes.

now the background random wallpaper switchings is working.

restart kcontrol/desktop/background

- disable "random"
- select "main" ok to apply the changes

Now the previously set wallpaper disappears and instead the color
gradient is used.


the following patch fixes this bug and also two others:

the two other problems are:

a) the random timer isn't deleted when the "random" gets deselected.
therefore kbgndwm keeps reloading the background even if there is no
longer a random setup. not much a problem, but hits performance

b) the given default for readBoolEntry("UseWallpaper") is wrong. it
should be DEFAULT_USE_WALLPAPER. This might lead to a problem if there
is no UseWallpaper given (very unlikely).

please tell me if you have success with this patch and if it breaks
something for you. please hurry! :)

=== Cut ===
Index: bg.cpp
===================================================================
RCS file: /home/kde/kdebase/kwmmodules/kbgndwm/Attic/bg.cpp,v
retrieving revision 1.33.2.8
diff -u -r1.33.2.8 bg.cpp
-+- bg.cpp 1999/08/23 10:34:55 1.33.2.8
+++ bg.cpp 1999/09/04 11:34:53
@@ -162,6 +162,13 @@
       randomDesk = DEFAULT_DESKTOP;
     }
   }
+  else {
+    if(timerRandom) {
+      delete timerRandom;
+      timerRandom = 0;
+    }
+    randomDesk = DEFAULT_DESKTOP;
+  }

   // this is mainly for kpager, so that we can at anytime find out how
desktop
   //          really looks
@@ -223,7 +230,7 @@
     wpMode = Scaled;

   wallpaper = DEFAULT_WALLPAPER;
-  bUseWallpaper = config.readBoolEntry( "UseWallpaper",
DEFAULT_WALLPAPER_MODE );
+  bUseWallpaper = config.readBoolEntry( "UseWallpaper",
DEFAULT_USE_WALLPAPER );
   if ( bUseWallpaper )
     wallpaper = config.readEntry( "Wallpaper", DEFAULT_WALLPAPER );

=== Cut ===

-- 
Dirk A. Mueller

[prev in list] [next in list] [prev in thread] [next in thread]