[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    please review kfinger patch
From:       "Dirk A. Mueller" <dmuell () gmx ! net>
Date:       1999-08-08 13:26:52
[Download RAW message or body]

Hi,

Please take a look at #1315:


can I commit the patch to KDE_1_1_BRANCH?

Package: kfinger
Version: 0.8.0

kfinger fails to build on Solaris 2.5.1 with the following error

In file included from /mnt/kde/kdenetwork-1.1.1/kfinger/finger.C:14:
/usr/include/sys/socket.h:143: syntax error before `;'
/usr/include/sys/socket.h:152: syntax error before `;'
/usr/include/sys/socket.h:153: syntax error before `;'
/usr/include/sys/socket.h:195: syntax error before `;'
/usr/include/sys/socket.h:199: syntax error before `;'
/usr/include/sys/socket.h:260: syntax error before `;'
/mnt/kde/kdenetwork-1.1.1/kfinger/finger.C: In method `int
FingerProtocol::write
String(class QString)':
/mnt/kde/kdenetwork-1.1.1/kfinger/finger.C:139: passing `int *' as
argument 4 of
 `getsockopt(int, int, int, char *, int *)'


This is because sys/socket.h needs sys/types.h and Solaris has an old
prototype for getsockopt that uses "char *" for the 4th argument

Following patch fixes both problems.

cheers
mark

+++ finger.C    Thu May  6 10:51:20 1999
@@ -11,9 +11,9 @@

 */
 #include <netdb.h>
+#include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/resource.h>
-#include <sys/types.h>
 #include <stdlib.h>
 #include <sys/time.h>
 #include <fcntl.h>
@@ -136,7 +136,7 @@
 {
     unsigned int len;
     int  val;
-    getsockopt(sock,SOL_SOCKET,SO_ERROR,&val,&len );

+    getsockopt(sock,SOL_SOCKET,SO_ERROR,(void *)&val,&len );

     if(val==0)
        write(sock,st,strlen(st));
     return val;



-- 
Dirk A. Mueller

[prev in list] [next in list] [prev in thread] [next in thread]