[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE Review: Hash-o-Matic
From:       Carl Schwan <carl () carlschwan ! eu>
Date:       2023-10-02 21:12:06
Message-ID: 5772471.DvuYhMxLoT () fedora
[Download RAW message or body]

On Monday, 2 October 2023 21:53:06 CEST Albert Astals Cid wrote:
> 
> This method of review is really sub-optiomal.
> 
> Who checked all those marks? There's no way to know.
> 
> Was it someone expert in the area?
> 
> Was it someone that knows has no idea what the checks mean?
> 
> Or was it the submitter of review? If it's the submitter for review it's
> worthless (nothing against Carl, you're great) but one doesn't review their
> own MRs, so one shouldn't probably review this kind of checks either.

I now unchecked all the checkmarks. For me I see these checkmarks as stuff I 
need to do before sending a mail to kde-core-devel, as it is just the basic 
stuff and it doesn't make sense to request a review if this is not done.

Cheers,
Carl




[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic