[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review of Codevis (ie - Making Codevis a KDE Project)
From: Tomaz Canabrava <tcanabrava () kde ! org>
Date: 2023-08-27 11:55:26
Message-ID: CACk01_yzm1RhVsNh_xvQkLu5zM_f=_SHgFAGdUdQcD0sEAiR-A () mail ! gmail ! com
[Download RAW message or body]
Update, now it works on windows and FreeBSD.
<3
On Tue, 22 Aug 2023 at 21:21 Tomaz Canabrava <tcanabrava@kde.org> wrote:
> Update, it now builds on qt6 and qt5.
> Struggling a bit with craft for windows.
>
>
> On Fri, 18 Aug 2023 at 21:22 Ben Cooksley <bcooksley@kde.org> wrote:
>
>> On Sat, Aug 19, 2023 at 3:37 AM Tomaz Canabrava <tcanabrava@kde.org>
>> wrote:
>>
>>> (some help / I need to set the default branch to master, from main,
>>> because the tooling doesn't accept the later, I don't think I have the
>>> permission to do that).
>>>
>>
>> That has been done now.
>>
>> Cheers,
>> Ben
>>
>>
>>>
>>> On Fri, Aug 18, 2023 at 5:10 PM Tomaz Canabrava <tcanabrava@kde.org>
>>> wrote:
>>>
>>>> Small update that the CI is now fully passing.
>>>>
>>>> On Fri, Aug 18, 2023 at 2:25 PM Tomaz Canabrava <tcanabrava@kde.org>
>>>> wrote:
>>>>
>>>>> Carl, Sysadmins:
>>>>>
>>>>> The current error on the KDE ci is this:
>>>>>
>>>>> Looking for clang tool headers at /usr/lib64/clang/16.0.6/include. You
>>>>> can change this by defining CT_CLANG_HEADERS_DIR
>>>>> CMake Error at CMakeLists.txt:87 (message):
>>>>> Cannot find clang tool headers at /usr/lib64/clang/16.0.6/include
>>>>> -- Configuring incomplete, errors occurred!
>>>>>
>>>>> (to which I understand that carl said there's an error with Clang6.
>>>>> This is not an error - it basically says that we are unable to find
>>>>> `stddef.h` on the path `
>>>>> ${LLVM_LIBRARY_DIR}/clang/${LLVM_PACKAGE_VERSION}/include`
>>>>>
>>>>> This is needed for the tool to run properly, but not compile, so I
>>>>> removed the FATAL from the message.
>>>>>
>>>>> On Thu, Aug 17, 2023 at 6:51 PM Tomaz Canabrava <tcanabrava@kde.org>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, 17 Aug 2023 at 18:29 Carl Schwan <carl.schwan@gnupg.com>
>>>>>> wrote:
>>>>>>
>>>>>>> On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote:
>>>>>>> > Hello Fellow KDE Devs,
>>>>>>> >
>>>>>>> > I'm here, formally asking for a review of the Codevis project, to
>>>>>>> move
>>>>>>> > forward and make it a part of kdesdk.
>>>>>>>
>>>>>>> Very cool project, I was amazed by the presentation of it from
>>>>>>> tarcisio at
>>>>>>> Akademy.
>>>>>>>
>>>>>>> > Currently we are using parts of KWdigetsAddons as a submodule
>>>>>>> > Most things that are related to buildsystems will be moved to
>>>>>>> craft /
>>>>>>> > kdesrc-build as soon as possible, right now we rely in conan for
>>>>>>> windows
>>>>>>> > and mac, plus a hand-written build script that downloads and
>>>>>>> builds llvm
>>>>>>> > for those platforms.
>>>>>>> >
>>>>>>> > Things that I know that are out of KDE Accordance:
>>>>>>> > - Translation System (uses Qt's tr() system)
>>>>>>>
>>>>>>> This isn't an issue and we have other KDE projects using the tr()
>>>>>>> system. But
>>>>>>> if you want to port to ki18n, it's best to do it now since you don't
>>>>>>> seems to
>>>>>>> have any translations yet.
>>>>>>>
>>>>>>> > - Settings System (it uses my own configuration parser that
>>>>>>> resembles QML)
>>>>>>>
>>>>>>> Yeah probably best to use kconfigxt or make your configuration
>>>>>>> parser part of
>>>>>>> kconfigxt next gen ;)
>>>>>>>
>>>>>>> > - Folder naming specification (follows the lakosian naming
>>>>>>> specification)
>>>>>>>
>>>>>>> I don't think we have any folder (and file) naming specification in
>>>>>>> kde, or at
>>>>>>> least if we have one, it varies a lot between projects.
>>>>>>>
>>>>>>> > - CI used is based on Gitlab, but fails on KDE
>>>>>>>
>>>>>>> When trying to build it on my laptop it failed, due to the
>>>>>>> requirement of
>>>>>>> clang 16. This might also be an issue with the kde ci on tumbleweed.
>>>>>>
>>>>>>
>>>>>> Carl,
>>>>>>
>>>>>> There's no requirement for clang16 (I build with 15, tarcisio builds
>>>>>> with 14, the previous ci had 13, I believe)
>>>>>>
>>>>>> Mind if you share the build logs?
>>>>>>
>>>>>> Best
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> > The current repository of Codevis is:
>>>>>>> > https://invent.kde.org/tcanabrava/codevis
>>>>>>> >
>>>>>>> > The KDE developers on this project are me, tarcisio fischer (that
>>>>>>> presented
>>>>>>> > Codevis on Akademy), and Richard Dale.
>>>>>>> >
>>>>>>> > Best regards,
>>>>>>> > Tomaz
>>>>>>>
>>>>>>>
[Attachment #3 (text/html)]
<div dir="auto">Update, now it works on windows and FreeBSD.</div><div \
dir="auto"><3 </div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Tue, 22 Aug 2023 at 21:21 Tomaz Canabrava <<a \
href="mailto:tcanabrava@kde.org">tcanabrava@kde.org</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="auto">Update, it now builds on qt6 and qt5.</div><div dir="auto">Struggling a \
bit with craft for windows.</div><div dir="auto"><br></div><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 18 Aug 2023 at 21:22 \
Ben Cooksley <<a href="mailto:bcooksley@kde.org" \
target="_blank">bcooksley@kde.org</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="ltr"><div dir="ltr">On Sat, Aug 19, 2023 at 3:37 AM Tomaz Canabrava <<a \
href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>> \
wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="ltr">(some help / I need to set the default branch to master, from main, because \
the tooling doesn't accept the later, I don't think I have the permission to \
do that).<br></div></blockquote><div><br></div><div>That has been done \
now.</div><div><br></div><div>Cheers,</div><div>Ben</div></div></div><div \
dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Fri, Aug 18, 2023 at 5:10 PM Tomaz Canabrava <<a \
href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="ltr"><div>Small update that the CI is now fully passing.</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 18, 2023 at \
2:25 PM Tomaz Canabrava <<a href="mailto:tcanabrava@kde.org" \
target="_blank">tcanabrava@kde.org</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="ltr"><div>Carl, Sysadmins:</div><div><br></div><div>The current error on the KDE \
ci is this:</div><div><br></div><div><code style="font-family:monospace"><div \
style="font-family:monospace"><span style="font-family:monospace">Looking for clang \
tool headers at /usr/lib64/clang/16.0.6/include. You can change this by defining \
CT_CLANG_HEADERS_DIR</span></div><div \
style="font-family:monospace"></div></code><code style="font-family:monospace"><div \
style="font-family:monospace"><span style="font-family:monospace">CMake Error at \
CMakeLists.txt:87 (message):</span></div><div \
style="font-family:monospace"></div></code><code style="font-family:monospace"><div \
style="font-family:monospace"><span style="font-family:monospace"> Cannot find clang \
tool headers at /usr/lib64/clang/16.0.6/include</span></div><div \
style="font-family:monospace"></div></code><code style="font-family:monospace"><span \
style="font-family:monospace">-- Configuring incomplete, errors \
occurred!</span></code></div><div><code style="font-family:monospace"><span \
style="font-family:monospace"><br></span></code></div><div><code \
style="font-family:monospace"><span style="font-family:monospace">(to which I \
understand that carl said there's an error with Clang6. This is not an error - it \
basically says that we are unable to find `stddef.h` on the path \
`</span></code>${LLVM_LIBRARY_DIR}/clang/${LLVM_PACKAGE_VERSION}/include`</div><div><br></div><div>This \
is needed for the tool to run properly, but not compile, so I removed the FATAL from \
the message.<br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, Aug 17, 2023 at 6:51 PM Tomaz Canabrava <<a \
href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
dir="auto"><br></div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, 17 Aug 2023 at 18:29 Carl Schwan <<a \
href="mailto:carl.schwan@gnupg.com" target="_blank">carl.schwan@gnupg.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On \
Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote:<br> > Hello \
Fellow KDE Devs,<br> > <br>
> I'm here, formally asking for a review of the Codevis project, to move<br>
> forward and make it a part of kdesdk.<br>
<br>
Very cool project, I was amazed by the presentation of it from tarcisio at <br>
Akademy.<br>
<br>
> Currently we are using parts of KWdigetsAddons as a submodule<br>
> Most things that are related to buildsystems will be moved to craft /<br>
> kdesrc-build as soon as possible, right now we rely in conan for windows<br>
> and mac, plus a hand-written build script that downloads and builds llvm<br>
> for those platforms.<br>
> <br>
> Things that I know that are out of KDE Accordance:<br>
> - Translation System (uses Qt's tr() system)<br>
<br>
This isn't an issue and we have other KDE projects using the tr() system. But \
<br> if you want to port to ki18n, it's best to do it now since you don't \
seems to <br> have any translations yet.<br>
<br>
> - Settings System (it uses my own configuration parser that resembles QML)<br>
<br>
Yeah probably best to use kconfigxt or make your configuration parser part of <br>
kconfigxt next gen ;)<br>
<br>
> - Folder naming specification (follows the lakosian naming specification)<br>
<br>
I don't think we have any folder (and file) naming specification in kde, or at \
<br> least if we have one, it varies a lot between projects.<br>
<br>
> - CI used is based on Gitlab, but fails on KDE<br>
<br>
When trying to build it on my laptop it failed, due to the requirement of <br>
clang 16. This might also be an issue with the kde ci on tumbleweed.</blockquote><div \
dir="auto"><br></div><div dir="auto">Carl,</div><div dir="auto"><br></div><div \
dir="auto">There's no requirement for clang16 (I build with 15, tarcisio builds with \
14, the previous ci had 13, I believe)</div><div dir="auto"><br></div><div \
dir="auto">Mind if you share the build logs?</div><div dir="auto"><br></div><div \
dir="auto">Best</div><div dir="auto"><br></div><div dir="auto"><br></div><div \
dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)" \
dir="auto"><br> <br>
> The current repository of Codevis is:<br>
> <a href="https://invent.kde.org/tcanabrava/codevis" rel="noreferrer" \
target="_blank">https://invent.kde.org/tcanabrava/codevis</a><br> > <br>
> The KDE developers on this project are me, tarcisio fischer (that presented<br>
> Codevis on Akademy), and Richard Dale.<br>
> <br>
> Best regards,<br>
> Tomaz<br>
<br>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic