[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Proposal for using gitlab for kdereview process
From:       Nicolas Fella <nicolas.fella () gmx ! de>
Date:       2023-02-17 12:43:21
Message-ID: 7f7e2dcc-2dcd-8313-a952-cfb5540f5705 () gmx ! de
[Download RAW message or body]

On 2/17/23 08:53, David Redondo wrote:
> Hi,
>
> I observed that participation in kdereview is fairly low. Usually only t=
he
> same few people participate (I have to admit this does not include me ei=
ther).
> Further follow up to their comments tends sometimes to be slow or is mis=
sed.
> Sometimes it fizzles out completely.
> I think nowadays we have better tools to streamline the whole process, w=
hich
> we are familiar with and make the barrier to participation lower. My ide=
a is
> to use Gitlab which we use for normal code review also for the kdereview
> process. For example it could be as follows
> - Announce the intention to go through kdereview as usual to kde-core-de=
vel
> - Create a MR in your project's repo from master branch into an empty
> kdereview branch
> - Could copy the sanity checklist [1] as task list and check things ther=
e
> - Reviewers can leave review comments in the familiar web interface
> - Commits that fix review comments are pushed to master branch and so up=
date
> the code seen in the MR
> - Once the reviewers are satisfied and their feedback incorporated, they
> approve the MR and it can be closed
>
> Thoughts?
>
> David
> [1] https://community.kde.org/ReleasingSoftware#Sanity_Checklist

Hi,

I definitely like the idea of a more structured approach to the review,
e.g. by following a checklist.

Currently it feels somewhat ad-hoc and arbitrary what people suggest (or
don't suggest), and it's not always clear what's "required" to pass and
what's more of an optional suggestion.

Cheers

Nico

[prev in list] [next in list] [prev in thread] [next in thread]