--nextPart1890571.obqo0Dhsen
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1"
From: Milian Wolff <mail@milianw.de>
Subject: Re: New santizer warning in KF 5.98 headers
Date: Wed, 11 Jan 2023 13:06:41 +0100
Message-ID: <1991634.2j93N3cfxU@milian-workstation>
In-Reply-To: <2271372.ElGaqSPkdT@daneel>
MIME-Version: 1.0

On Mittwoch, 11. Januar 2023 11:26:42 CET Ingo Kl=F6cker wrote:
> On Mittwoch, 11. Januar 2023 11:02:04 CET Milian Wolff wrote:
> > On Dienstag, 10. Januar 2023 23:45:26 CET Michael Reeves wrote:
> > > Thanks. I would say your right there this would definitely have caught
> > > someone's attention if didn't work in practice with what kde needs.
> > > Santizers are by design quite pedantic as serves there purpose well.
> >=20
> > I agree, the code is clearly wrong and it's unclear what it's trying to
> > achieve here. Does anyone know what this is trying to do?
> >=20
> > Qt::ConnectionType connectionType =3D static_cast<Qt::ConnectionType>(-=
1)
> >=20
> > Should this maybe just be changed to use Qt::AutoConnection?
>=20
> The code:
> https://invent.kde.org/frameworks/kconfigwidgets/-/blob/master/src/
> kstandardaction.h#L253
>=20
> What the code does:
> The default value `static_cast<Qt::ConnectionType>(-1)` serves as hint th=
at
> the function should decide what kind of connection type to use and for so=
me
> reason the `ConfigureToolbars` action explicitly needs to use a
> `Qt::QueuedConnection` instead of a `Qt::AutoConnection`. This could be
> changed to a std::optional (for KF6) to make the intention clear.

Indeed, I should have read the body of the function and not stop at the=20
signature only :)

Thanks for the explanation Ingo! And std::optional for KF6 would be great i=
mo,=20
if this is really needed.

> Why the code does what it does:
> One could question whether this special casing for `ConfigureToolbars` is
> still necessary. The bug report about the crash that this seems to have
> fixed is from 2009: https://bugs.kde.org/show_bug.cgi?id=3D200815
>=20
> Regards,
> Ingo


=2D-=20
Milian Wolff
mail@milianw.de
http://milianw.de
--nextPart1890571.obqo0Dhsen
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEezawi1aUvUGg3A1+8zYW/HGdOX8FAmO+plEACgkQ8zYW/HGd
OX9L+w//TjeGC+0l57t9R15siKNHkS4C8sYxQQls5LD80rRm1K/S6cXDIbpZnQtI
EA78noDGhqstTsPLQHmF108hrjliosU7DQnENXq3Aib729nteQmLgUTH7y/PNT0B
3t+MntJc8OYgMVKIJQO2MIxD7BBvBnnDQ0iP/7j/RAY2hjVe8YNCIsS4rrSfos9a
+PDkKO7ZLgmRcZ/un5g1OxtO9Go/DCeLvaI+wr7rarED3cnl9W0WLIT9BAUW3ReT
wrF4z89W0Kt04QvsNxq/dUdlQBj9mNJ20+Ib0IJIMJycerQWXd5xqScmmXxe3MPa
uB+Dne8hCoSEP66Ifg0/rN8aU5hU21b0mfhC8JyiPztR6CVlkD+zFs614NiKW4gS
pVjQ72tVS9Mb+enlMt9lr9+VaWi6cOOSbmNJ8oMKQDU9ToZIrrxRAYhlqPnr1g2y
+9N967xvYZ25BhiXjOyPOc0qQJxrcs+BCu3NdiAgMpWwmUQwIpF8fZAt5wqEVj/G
tgRjuiGzDFidNPLgLBqY1IeFTRn6ZN/jQkOyW9j1zoFytFtnoDYdWiAkR2r1mWGE
Pig8uw0l8XEZhzRSSVMfenLCchRi3oCKE9l1M0JEkSDzHNLsgMFyt/l9/DFebv8u
jA6KZPQzjcHdvkraeqTP6u2r60Yq510wIm+uzsGycuPav3s+JH8=
=uYi6
-----END PGP SIGNATURE-----

--nextPart1890571.obqo0Dhsen--