[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: New repo in kdereview: KWeather
From:       Devin <espidev () gmail ! com>
Date:       2022-11-25 3:46:40
Message-ID: CAEs_zxA1fi44kk8JENFN62YtDDjj2swiuaT3zOWHJH4BHtsbVw () mail ! gmail ! com
[Download RAW message or body]

> There's potentially overlapping text.

I have fixed text wrapping in the weather delegates so it should wrap
properly now.

> Here settingsModel.forecastStyle is not i18n'ed

I have fixed it now (it converts to i18n'd dedicated strings in the QML)

On Mon, Nov 14, 2022 at 5:10 PM Albert Astals Cid <aacid@kde.org> wrote:
>
> El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure:
> > Hi everyone,
> >
> > I would like to put kweather through kdereview:
> >
> > https://invent.kde.org/plasma-mobile/kweather
> >
> > KWeather is an application that can give simple weather information
> > for different weather locations. Please note that KWeatherCore (the
> > library the app depends on) has already passed kdereview.
>
> There's potentially overlapping text.
>
> See https://i.imgur.com/BrOgi3A.png
>
> The settings show untranslateable text, i.e.
>
> MobileForm.FormComboBoxDelegate {
>                 id: forecastStyleDropdown
>                 text: i18n("Forecast Style")
>                 currentValue: settingsModel.forecastStyle
>
> Here settingsModel.forecastStyle is not i18n'ed
>
> Not KWeather's fault but i just realized that Kirigami's about page doesn't
> properly credit translators :/
>
> Cheers,
>   Albert
>
> >
> > Thanks,
> > Devin
>
>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]