[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: New repo in kdereview: KWeather
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2022-11-09 22:37:08
Message-ID: CADWV2K6Pppe4vKce03HVxJCh=1LPg0vtvfuupDGkCz5PD8MDZw () mail ! gmail ! com
[Download RAW message or body]
After installing kirigami-addons it runs fine, adding my location went
smooth, etc. Only nitpick I found as a user was that it's a bit weird that
Settings -> About changes the main window instead of showing about data in
the little settings window. I would suggest making About be one of the
buttons on the main window, or showing the about data in the settings
window.
On Wed, Nov 9, 2022 at 3:31 PM Jeremy Whiting <jeremypwhiting@gmail.com>
wrote:
> Looks like it's got a runtime dependency on kirigami (Maybe that's
> expected for plasma-mobile, not sure)
>
> Built it on laptop and got this from cmake:
>
> cmake ..
> -- The C compiler identification is GNU 12.2.0
> -- The CXX compiler identification is GNU 12.2.0
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Check for working C compiler: /usr/bin/cc - skipped
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Check for working CXX compiler: /usr/bin/c++ - skipped
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found
> components: Interpreter
> -- Could NOT find ReuseTool (missing: REUSETOOL_EXECUTABLE)
> CMake Warning at /usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86
> (message):
> Reuse tool not found, skipping test generation
> Call Stack (most recent call first):
> CMakeLists.txt:30 (include)
>
>
> -- Skipping execution of outbound license tests.
> -- Installing in the same prefix as Qt, adopting their path scheme.
> -- Setting build type to 'Debug' as none was specified.
> -- Looking for __GLIBC__
> -- Looking for __GLIBC__ - found
> -- Performing Test _OFFT_IS_64BIT
> -- Performing Test _OFFT_IS_64BIT - Success
> -- Performing Test HAVE_DATE_TIME
> -- Performing Test HAVE_DATE_TIME - Success
> -- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake
> (found version "5.99.0")
> -- Found KF5Kirigami2:
> /usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version
> "5.99.0")
> -- Found Gettext: /usr/bin/msgmerge (found version "0.21.1")
> -- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found
> version "5.99.0")
> -- Found KF5CoreAddons:
> /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version
> "5.99.0")
> -- Found KF5Notifications:
> /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found
> version "5.99.0")
> -- Found KF5: success (found suitable version "5.99.0", minimum required
> is "5.90.0") found components: Config Kirigami2 I18n CoreAddons
> Notifications
> -- Found X11: /usr/include
> -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so
> -- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so -
> found
> -- Looking for gethostbyname
> -- Looking for gethostbyname - found
> -- Looking for connect
> -- Looking for connect - found
> -- Looking for remove
> -- Looking for remove - found
> -- Looking for shmat
> -- Looking for shmat - found
> -- Looking for IceConnectionNumber in ICE
> -- Looking for IceConnectionNumber in ICE - found
> -- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake
> (found version "5.99.0")
> -- Found KF5: success (found suitable version "5.99.0", minimum required
> is "5.90.0") found components: Plasma
> -- Found org.kde.kholidays-QMLModule: TRUE (found version "")
> -- The following RUNTIME packages have been found:
>
> * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a runtime
> dependency.
>
> -- The following OPTIONAL packages have been found:
>
> * Python3
> Required to run tests of module ECMCheckOutboundLicense
> * Qt5QuickCompiler
> * KF5Package (required version >= 5.99.0)
> * KF5Service (required version >= 5.99.0)
> * Freetype
> * PkgConfig
> * Fontconfig
>
> -- The following REQUIRED packages have been found:
>
> * ECM (required version >= 5.90.0)
> * Qt5Network (required version >= 5.15.7)
> * Qt5QmlModels (required version >= 5.15.7)
> * Qt5Quick
> * Qt5Test
> * Qt5Svg
> * Qt5QuickControls2
> * Qt5Charts
> * KF5Kirigami2 (required version >= 5.90.0)
> * Gettext
> * KF5I18n (required version >= 5.90.0)
> * KF5Notifications (required version >= 5.90.0)
> * KF5KWeatherCore (required version >= 0.6.0)
> * KF5CoreAddons (required version >= 5.99.0)
> * Qt5Gui (required version >= 5.15.2)
> * Qt5Widgets (required version >= 5.15.2)
> * KF5Plasma (required version >= 5.90.0)
> * KF5 (required version >= 5.90.0)
> * Qt5Qml
> * Qt5Core
> * Qt5
>
> -- The following features have been disabled:
>
> * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX
> definitions (requires reuse tool)
>
> -- The following OPTIONAL packages have not been found:
>
> * ReuseTool
> Required to run tests of module ECMCheckOutboundLicense
>
> -- Configuring done
> -- Generating done
> -- Build files have been written to:
> /home/jeremy/data/devel/kde/src/kde/plasma-mobile/kweather/build
>
> then it built and installed fine, but trying to run failed with this:
>
> kweather
> QQmlApplicationEngine failed to load component
> qrc:/qml/main.qml:163:26: Type SettingsDialog unavailable
> qrc:/qml/settings/SettingsDialog.qml:33:22: Type SettingsComponent
> unavailable
> qrc:/qml/settings/SettingsComponent.qml:13:1: module
> "org.kde.kirigamiaddons.labs.mobileform" is not installed
>
> maybe cmake should have said it depends on kirigami?
>
> On Wed, Nov 9, 2022 at 3:00 PM Devin <espidev@gmail.com> wrote:
>
>> Hi everyone,
>>
>> I would like to put kweather through kdereview:
>>
>> https://invent.kde.org/plasma-mobile/kweather
>>
>> KWeather is an application that can give simple weather information
>> for different weather locations. Please note that KWeatherCore (the
>> library the app depends on) has already passed kdereview.
>>
>> Thanks,
>> Devin
>>
>
[Attachment #3 (text/html)]
<div dir="ltr"><div class="gmail_default" style="font-family:monospace">After \
installing kirigami-addons it runs fine, adding my location went smooth, etc. Only \
nitpick I found as a user was that it's a bit weird that Settings -> About \
changes the main window instead of showing about data in the little settings window. \
I would suggest making About be one of the buttons on the main window, or showing the \
about data in the settings window.<br></div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Wed, Nov 9, 2022 at 3:31 PM Jeremy Whiting <<a \
href="mailto:jeremypwhiting@gmail.com">jeremypwhiting@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
class="gmail_default" style="font-family:monospace">Looks like it's got a runtime \
dependency on kirigami (Maybe that's expected for plasma-mobile, not \
sure)</div><div class="gmail_default" style="font-family:monospace"><br></div><div \
class="gmail_default" style="font-family:monospace">Built it on laptop and got this \
from cmake:</div><div class="gmail_default" \
style="font-family:monospace"><br></div><div class="gmail_default" \
style="font-family:monospace"><span style="font-family:monospace"><span \
style="color:rgb(0,0,0);background-color:rgb(255,255,255)">cmake .. </span><br>-- The \
C compiler identification is GNU 12.2.0 <br>-- The CXX compiler identification is GNU \
12.2.0 <br>-- Detecting C compiler ABI info
<br>-- Detecting C compiler ABI info - done
<br>-- Check for working C compiler: /usr/bin/cc - skipped
<br>-- Detecting C compile features
<br>-- Detecting C compile features - done
<br>-- Detecting CXX compiler ABI info
<br>-- Detecting CXX compiler ABI info - done
<br>-- Check for working CXX compiler: /usr/bin/c++ - skipped
<br>-- Detecting CXX compile features
<br>-- Detecting CXX compile features - done
<br>-- Found Python3: /usr/bin/python3.10 (found version "3.10.8") found \
components: Interpreter <br>-- Could NOT find ReuseTool (missing: \
REUSETOOL_EXECUTABLE) <br><span \
style="color:rgb(178,104,24);background-color:rgb(255,255,255)">CMake Warning at \
/usr/share/ECM/modules/ECMCheckOutboundLicense.cmake:86 (message):</span><span \
style="color:rgb(0,0,0);background-color:rgb(255,255,255)"> </span><br><span \
style="color:rgb(178,104,24);background-color:rgb(255,255,255)"> Reuse tool not \
found, skipping test generation</span><span \
style="color:rgb(0,0,0);background-color:rgb(255,255,255)"> </span><br><span \
style="color:rgb(178,104,24);background-color:rgb(255,255,255)">Call Stack (most \
recent call first):</span><span \
style="color:rgb(0,0,0);background-color:rgb(255,255,255)"> </span><br><span \
style="color:rgb(178,104,24);background-color:rgb(255,255,255)"> CMakeLists.txt:30 \
(include)</span><span style="color:rgb(0,0,0);background-color:rgb(255,255,255)"> \
</span><br> <br>
<br>-- Skipping execution of outbound license tests.
<br>-- Installing in the same prefix as Qt, adopting their path scheme.
<br>-- Setting build type to 'Debug' as none was specified.
<br>-- Looking for __GLIBC__
<br>-- Looking for __GLIBC__ - found
<br>-- Performing Test _OFFT_IS_64BIT
<br>-- Performing Test _OFFT_IS_64BIT - Success
<br>-- Performing Test HAVE_DATE_TIME
<br>-- Performing Test HAVE_DATE_TIME - Success
<br>-- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found \
version "5.99.0") <br>-- Found KF5Kirigami2: \
/usr/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version \
"5.99.0") <br>-- Found Gettext: /usr/bin/msgmerge (found version \
"0.21.1") <br>-- Found KF5I18n: \
/usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.99.0") \
<br>-- Found KF5CoreAddons: /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake \
(found version "5.99.0") <br>-- Found KF5Notifications: \
/usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version \
"5.99.0") <br>-- Found KF5: success (found suitable version \
"5.99.0", minimum required is "5.90.0") found components: Config \
Kirigami2 I18n CoreAddons Notifications <br>-- Found X11: /usr/include <br>-- \
Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so <br>-- Looking for \
XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so - found <br>-- Looking for \
gethostbyname <br>-- Looking for gethostbyname - found
<br>-- Looking for connect
<br>-- Looking for connect - found
<br>-- Looking for remove
<br>-- Looking for remove - found
<br>-- Looking for shmat
<br>-- Looking for shmat - found
<br>-- Looking for IceConnectionNumber in ICE
<br>-- Looking for IceConnectionNumber in ICE - found
<br>-- Found KF5Plasma: /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found \
version "5.99.0") <br>-- Found KF5: success (found suitable version \
"5.99.0", minimum required is "5.90.0") found components: Plasma \
<br>-- Found org.kde.kholidays-QMLModule: TRUE (found version "") \
<br>-- The following RUNTIME packages have been found: <br>
<br> * org.kde.kholidays-QMLModule, QML module 'org.kde.kholidays' is a \
runtime dependency. <br>
<br>-- The following OPTIONAL packages have been found:
<br>
<br> * Python3
<br> Required to run tests of module ECMCheckOutboundLicense
<br> * Qt5QuickCompiler
<br> * KF5Package (required version >= 5.99.0)
<br> * KF5Service (required version >= 5.99.0)
<br> * Freetype
<br> * PkgConfig
<br> * Fontconfig
<br>
<br>-- The following REQUIRED packages have been found:
<br>
<br> * ECM (required version >= 5.90.0)
<br> * Qt5Network (required version >= 5.15.7)
<br> * Qt5QmlModels (required version >= 5.15.7)
<br> * Qt5Quick
<br> * Qt5Test
<br> * Qt5Svg
<br> * Qt5QuickControls2
<br> * Qt5Charts
<br> * KF5Kirigami2 (required version >= 5.90.0)
<br> * Gettext
<br> * KF5I18n (required version >= 5.90.0)
<br> * KF5Notifications (required version >= 5.90.0)
<br> * KF5KWeatherCore (required version >= 0.6.0)
<br> * KF5CoreAddons (required version >= 5.99.0)
<br> * Qt5Gui (required version >= 5.15.2)
<br> * Qt5Widgets (required version >= 5.15.2)
<br> * KF5Plasma (required version >= 5.90.0)
<br> * KF5 (required version >= 5.90.0)
<br> * Qt5Qml
<br> * Qt5Core
<br> * Qt5
<br>
<br>-- The following features have been disabled:
<br>
<br> * SPDX_LICENSE_TESTING, Automatic license testing based on SPDX definitions \
(requires reuse tool) <br>
<br>-- The following OPTIONAL packages have not been found:
<br>
<br> * ReuseTool
<br> Required to run tests of module ECMCheckOutboundLicense
<br>
<br>-- Configuring done
<br>-- Generating done
<br>-- Build files have been written to: \
/home/jeremy/data/devel/kde/src/kde/plasma-mobile/kweather/build<br> \
<br></span></div><div class="gmail_default" style="font-family:monospace"><span \
style="font-family:monospace">then it built and installed fine, but trying to run \
failed with this:</span></div><div class="gmail_default" \
style="font-family:monospace"><span \
style="font-family:monospace"><br></span></div><div class="gmail_default" \
style="font-family:monospace"><span style="font-family:monospace"><span \
style="font-family:monospace"><span \
style="color:rgb(0,0,0);background-color:rgb(255,255,255)"> kweather \
</span><br>QQmlApplicationEngine failed to load component \
<br>qrc:/qml/main.qml:163:26: Type SettingsDialog unavailable \
<br>qrc:/qml/settings/SettingsDialog.qml:33:22: Type SettingsComponent unavailable \
<br>qrc:/qml/settings/SettingsComponent.qml:13:1: module \
"org.kde.kirigamiaddons.labs.mobileform" is not installed<br> \
<br></span></span></div><div class="gmail_default" \
style="font-family:monospace"><span style="font-family:monospace"><span \
style="font-family:monospace">maybe cmake should have said it depends on \
kirigami?<br></span></span></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Wed, Nov 9, 2022 at 3:00 PM Devin <<a \
href="mailto:espidev@gmail.com" target="_blank">espidev@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi everyone,<br> <br>
I would like to put kweather through kdereview:<br>
<br>
<a href="https://invent.kde.org/plasma-mobile/kweather" rel="noreferrer" \
target="_blank">https://invent.kde.org/plasma-mobile/kweather</a><br> <br>
KWeather is an application that can give simple weather information<br>
for different weather locations. Please note that KWeatherCore (the<br>
library the app depends on) has already passed kdereview.<br>
<br>
Thanks,<br>
Devin<br>
</blockquote></div>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic