[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KJournald in KDE-Review
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2022-10-09 21:19:51
Message-ID: 1770887.S3qJccl16G () xps15
[Download RAW message or body]

El diumenge, 9 d'octubre de 2022, a les 19:18:15 (CEST), Andreas Cord-Landwehr va \
escriure:
> Hi, after a few releases over the past year, I would like to get KJournald
> included in KDE application releases. This project is about providing both
> an QItemModel abstraction library for the C-style journald API and
> providing an efficient graphical browser for journald logs.
> 
> Sysadmins moved the repository to KDE Review today, you can find the source
> code here:
> 
> https://invent.kde.org/libraries/kjournald
> 
> (flatpack packaging is also available for easy trying it out)
> 
> Even though KJournald is currently contained in the "libraries" playground
> module, I would like to get it included in the "utilities" module after
> passing KDE Review. The reason is that at the moment I more focus on the
> application part and that is the most user-facing part. Having it in
> "utilities" thus will avoid confusion.
> 
> Looking forward for your review comments!

automoc complains a bit about some properties https://pst.klgrth.io/paste/kf9ta
If you're planning to use those from QML maybe a Q_INVOKABLE is better?

You need to use -DTRANSLATION_DOMAIN on your library (i understand it's supposed to \
be usable by third party apps)

valgrind is reporting a massive memory leak, you need to free the char* returned by \
sd_journal_get_cursor

Cheers,
  Albert

> 
> Best regards,
> Andreas


[prev in list] [next in list] [prev in thread] [next in thread]