[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Putting Flatpak KCM through kdereview
From:       Harald Sitter <sitter () kde ! org>
Date:       2022-09-09 12:30:17
Message-ID: CAEc+18FhrEDT00qcX7ZRUV_qZLrAadqP3bQSiE3npKLu=WDjBA () mail ! gmail ! com
[Download RAW message or body]

Amazing!

For future reference: there is a sanity check list linked at
https://community.kde.org/Policies/Application_Lifecycle#kdereview
that you can follow to do a pre-review yourself and find most common
issues.

- Messages.sh missing (I see there is an MR pending)
- you should enable CI and in particular also enable the reuse
template to ensure reuse compliance moving forward
- the KCM name has a "Settings" suffix, that seems rather uncoming,
I'd remove it
- clazy is not happy with some stuff, I suggest you do a compile run
with it and fix its complaints
- missing a bugzilla product (request one via sysadmin ticket)
- missing an appstream file
- I have a rather large margin on the right hand side of the permissions view :O
- please always use i18nc() rather than i18n() for new strings and
provide suitable context. in particular for one-word strings... to a
translator it won't at all be obvious in what context "features"
appears or what "pcsc" refers to

All in all really good stuff.

HS
[prev in list] [next in list] [prev in thread] [next in thread]