[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Eloquens now on KDEREVIEW)
From: Tomaz Canabrava <tcanabrava () kde ! org>
Date: 2022-09-03 9:39:53
Message-ID: CACk01_xrWzrgKSFKa1tqwXpZ6x-WzGN7NTqZwOPVsC3hS+61CA () mail ! gmail ! com
[Download RAW message or body]
Hello All,
All discussion was resolved by Felipe in the past few weeks,
I Assume this is done, and should be moved out of KDE Review?
Best.
On Tue, Jun 28, 2022 at 4:54 PM Felipe Kinoshita <kinofhek@gmail.com> wrote:
> friendly ping! :)
>
> On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita <kinofhek@gmail.com>
> wrote:
> >
> > > Ah! I would suggest moving the conversion into the Controller then. As
> > > far as kcfg, your Config object and your Settings.qml are concerned
> > > they can be proper bools, it's only in the Controller that you have
> > > the presentation requirement that bools must be 0/1. This saves you
> > > the two-way conversion, in the Controller you only need to convert
> > > bool=>int and the rest of the app can treat them as proper bools.
> >
> > Indeed, this makes much more sense.
> >
> > Fixed it now!
> >
> > Thanks,
> > Felipe
> >
> > On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter <sitter@kde.org> wrote:
> > >
> > > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita <kinofhek@gmail.com>
> wrote:
> > > >
> > > > > Could you elaborate why your config.kcfg uses Ints for everything
> when
> > > > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`)
> > > >
> > > > The API expects ones and zeros for its params, I chose to convert
> them to
> > > > booleans to make the API call easier to write and change.
> > >
> > > Ah! I would suggest moving the conversion into the Controller then. As
> > > far as kcfg, your Config object and your Settings.qml are concerned
> > > they can be proper bools, it's only in the Controller that you have
> > > the presentation requirement that bools must be 0/1. This saves you
> > > the two-way conversion, in the Controller you only need to convert
> > > bool=>int and the rest of the app can treat them as proper bools.
> > >
> > > HS
>
[Attachment #3 (text/html)]
<div dir="ltr"><div>Hello All,</div><div><br></div><div>All discussion was resolved \
by Felipe in the past few weeks,</div><div>I Assume this is done, and should be moved \
out of KDE Review?</div><div><br></div><div>Best.</div><div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 28, 2022 at 4:54 PM \
Felipe Kinoshita <<a href="mailto:kinofhek@gmail.com">kinofhek@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">friendly ping! :)<br> \
<br> On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita <<a \
href="mailto:kinofhek@gmail.com" target="_blank">kinofhek@gmail.com</a>> \
wrote:<br> ><br>
> > Ah! I would suggest moving the conversion into the Controller then. As<br>
> > far as kcfg, your Config object and your Settings.qml are concerned<br>
> > they can be proper bools, it's only in the Controller that you have<br>
> > the presentation requirement that bools must be 0/1. This saves you<br>
> > the two-way conversion, in the Controller you only need to convert<br>
> > bool=>int and the rest of the app can treat them as proper bools.<br>
><br>
> Indeed, this makes much more sense.<br>
><br>
> Fixed it now!<br>
><br>
> Thanks,<br>
> Felipe<br>
><br>
> On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter <<a \
href="mailto:sitter@kde.org" target="_blank">sitter@kde.org</a>> wrote:<br> > \
><br> > > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita <<a \
href="mailto:kinofhek@gmail.com" target="_blank">kinofhek@gmail.com</a>> \
wrote:<br> > > ><br>
> > > > Could you elaborate why your config.kcfg uses Ints for everything \
when<br> > > > > you clearly want booleans (e.g. `Config.code == 1 ? true \
: false`)<br> > > ><br>
> > > The API expects ones and zeros for its params, I chose to convert them \
to<br> > > > booleans to make the API call easier to write and change.<br>
> ><br>
> > Ah! I would suggest moving the conversion into the Controller then. As<br>
> > far as kcfg, your Config object and your Settings.qml are concerned<br>
> > they can be proper bools, it's only in the Controller that you have<br>
> > the presentation requirement that bools must be 0/1. This saves you<br>
> > the two-way conversion, in the Controller you only need to convert<br>
> > bool=>int and the rest of the app can treat them as proper bools.<br>
> ><br>
> > HS<br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic