[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Plasma Bigscreen is in kdereview again
From: Aditya Mehra <aix.m () outlook ! com>
Date: 2022-07-08 11:50:35
Message-ID: ME3P282MB41962AE62296F1415B52B8E6EF829 () ME3P282MB4196 ! AUSP282 ! PROD ! OUTLOOK ! COM
[Download RAW message or body]
Hi,
thanks for the review, most of the issues mentioned have now been fixed exc=
ept the reuse compliance, would be great if it can be glanced over again
Regards,
Aditya
________________________________
From: Harald Sitter <sitter@kde.org>
Sent: Friday, June 24, 2022 9:55 PM
To: Aditya Mehra <aix.m@outlook.com>
Cc: kde-core-devel <kde-core-devel@kde.org>
Subject: Re: Plasma Bigscreen is in kdereview again
- not fully reuse compliant. much sad but probably can't be helped
this far into the project :((
- kdeconnect.h has include guards for wifi.h
- kcm_mediacenter_bigscreen_settings may be missing a -DTRANSLATION_DOMAIN
- I would suggest you build with clazy. there are numerous possible
container detachments you could prevent. also many other reasonable
warnings
- you appear to not have an appstream file for the product. is that intenti=
onal?
I've only glanced over the code but it all seems fairly reasonable.
HS
On Fri, Jun 24, 2022 at 2:00 PM Aditya Mehra <aix.m@outlook.com> wrote:
>
> Bump!
>
> Plasma Bigscreen has been in review for a while, can it please be reviewe=
d or released assuming no problems have been detected ? Request to please t=
ake this forward as we would like to get proper stable packaging for it wit=
h distributions with the next plasma release.
>
> Regards,
> Aditya
> ________________________________
> From: Aditya Mehra
> Sent: Friday, May 6, 2022 1:53 AM
> To: kde-core-devel <kde-core-devel@kde.org>
> Subject: Plasma Bigscreen is in kdereview again
>
> Hello,
>
> Plasma Bigscreen is in KDE Review again, it was in review the last time a=
nd as development went on, we did not leave playground and the review was d=
ropped on our part, sorry. I would like to request you to please review Pla=
sma Bigscreen again as we would like to make a release for it. The reposito=
ry url is https://invent.kde.org/plasma/plasma-bigscreen
>
> Plasma Bigscreen project consist of a containment for Plasma aimed at a S=
mart TV interface, it is host to a grid based tile launcher for application=
s and some specific kcms like wifi, audio devices, launcher settings, and k=
de connect which can all be navigated with just a usb based remote, hdmi ce=
c connected tv remote, kde connect bigscreen plugin or arrow key navigation=
on a keyboard.
>
> The project is also integrated with the Mycroft voice assistant open sour=
ce project, to supports voice commands and Mycroft skills QML interface for=
providing graphical voice applications.
>
> Regards,
> Aditya
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} \
</style> </head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: \
rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Hi,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: \
rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: \
rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> thanks for the review, most of \
the issues mentioned have now been fixed except the reuse compliance, would be great \
if it can be glanced over again<br> </div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: \
rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: \
rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Regards,
<div>Aditya</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" \
style="font-size:11pt" color="#000000"><b>From:</b> Harald Sitter \
<sitter@kde.org><br> <b>Sent:</b> Friday, June 24, 2022 9:55 PM<br>
<b>To:</b> Aditya Mehra <aix.m@outlook.com><br>
<b>Cc:</b> kde-core-devel <kde-core-devel@kde.org><br>
<b>Subject:</b> Re: Plasma Bigscreen is in kdereview again</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">- not fully reuse compliant. much sad but probably can't be \
helped<br> this far into the project :((<br>
- kdeconnect.h has include guards for wifi.h<br>
- kcm_mediacenter_bigscreen_settings may be missing a -DTRANSLATION_DOMAIN<br>
- I would suggest you build with clazy. there are numerous possible<br>
container detachments you could prevent. also many other reasonable<br>
warnings<br>
- you appear to not have an appstream file for the product. is that intentional?<br>
<br>
I've only glanced over the code but it all seems fairly reasonable.<br>
HS<br>
<br>
<br>
On Fri, Jun 24, 2022 at 2:00 PM Aditya Mehra <aix.m@outlook.com> wrote:<br>
><br>
> Bump!<br>
><br>
> Plasma Bigscreen has been in review for a while, can it please be reviewed or \
released assuming no problems have been detected ? Request to please take this \
forward as we would like to get proper stable packaging for it with distributions \
with the next plasma release.<br>
><br>
> Regards,<br>
> Aditya<br>
> ________________________________<br>
> From: Aditya Mehra<br>
> Sent: Friday, May 6, 2022 1:53 AM<br>
> To: kde-core-devel <kde-core-devel@kde.org><br>
> Subject: Plasma Bigscreen is in kdereview again<br>
><br>
> Hello,<br>
><br>
> Plasma Bigscreen is in KDE Review again, it was in review the last time and as \
development went on, we did not leave playground and the review was dropped on our \
part, sorry. I would like to request you to please review Plasma Bigscreen again as \
we would like to make a release for it. The repository url is <a \
href="https://invent.kde.org/plasma/plasma-bigscreen"> \
https://invent.kde.org/plasma/plasma-bigscreen</a><br> ><br>
> Plasma Bigscreen project consist of a containment for Plasma aimed at a Smart TV \
interface, it is host to a grid based tile launcher for applications and some \
specific kcms like wifi, audio devices, launcher settings, and kde connect which can \
all be navigated with just a usb based remote, hdmi cec connected tv remote, kde \
connect bigscreen plugin or arrow key navigation on a keyboard.<br> ><br>
> The project is also integrated with the Mycroft voice assistant open source \
project, to supports voice commands and Mycroft skills QML interface for providing \
graphical voice applications.<br> ><br>
> Regards,<br>
> Aditya<br>
</div>
</span></font></div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic