[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: New repo in kdereview: kalk
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2021-05-01 22:04:34
Message-ID: 4320321.MadAUcZrqk () xps
[Download RAW message or body]

El dissabte, 1 de maig de 2021, a les 7:26:24 (CEST), hanyoung va escriure:
> I've fixed the keyboard bug and change the division result between two integers to \
> float. 

I don't think that changing knumber to do that is a great idea, keeping integer \
divisions as fraction instead of float seems the correct thing to do, you should \
instead change the ui to be able to show fractions as floats but to keep the internal \
representation as good as possible, i.e. as a fraction.

Not sure if related to that or not, but now if i type
65 / 9 = * 7 = 

i get 1.39999e+16 which doesn't seem correct, should be 50,5555...

I'd really suggest you add autotests for this.

Cheers,
  Albert

> Also the qml warning has been fixed.
> 
> Regards,
> Han
> 
> ------- Original Message -------
> On Saturday, May 1, 2021 5:13 AM, Albert Astals Cid <aacid@kde.org> wrote:
> 
> > El divendres, 30 d'abril de 2021, a les 15:31:11 (CEST), hanyoung va escriure:
> > 
> > > Kalk has now switched to the (modified) KNumber as base data type now. The real \
> > > number precision is hard coded to 16 for now. Also during SoK, binary mode was \
> > > introduced.
> > 
> > Running it i get
> > 
> > qrc:/qml/CalculationPage.qml:85: TypeError: Property 'binaryMode' of object \
> > InputManager(0x55ab4db7cac0) is not a function 
> > Keyboard input seems broken (typing one 6 i get two of them to show up)
> > 
> > Dividing doesn't work https://i.imgur.com/Zr04aki.gif
> > 
> > Cheers,
> > Albert
> 
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]