[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: New repo in kdereview: plasma-settings
From:       Harald Sitter <sitter () kde ! org>
Date:       2021-02-16 13:48:12
Message-ID: fa62d07c-d567-d8d8-ae95-30875ee6108a () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 15.02.21 07:16, Bhushan Shah wrote:
> Forwarding message, since had wrong reply to address in previous message
> 
> ----- Forwarded message from Bhushan Shah <bshah@mykolab.com> -----
> 
> Date: Mon, 15 Feb 2021 11:44:14 +0530
> From: Bhushan Shah <bshah@mykolab.com>
> To: Harald Sitter <sitter@kde.org>
> Subject: Re: New repo in kdereview: plasma-settings
> 
> On Mon, Jan 25, 2021 at 03:29:18PM +0100, Harald Sitter wrote:
>> Not sure if intentional but ModulesModel actually doesn't constrain to
>> settings KCMS. It'd also display info center kcms as well as (I think)
>> plugin KCMS (e.g. krunner's)
> 
> It is not intentional, but thinking about this I think it is fine, we
> are filtering them out based PLASMA_PLATFORM anyway.
> 
>> not installing a hicolor icon
> 
> We are reusing system settings icon from theme anyway, so not sure if I
> need to install something?

Fair points. +1

HS


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]