[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Plasma Firewall on KDE Review
From:       Tomaz Canabrava <tcanabrava () kde ! org>
Date:       2021-01-25 20:58:45
Message-ID: CACk01_w6oFF6xE_Uc1vM71FWdbM7HN+vB5tF8=+FgxJJdV8uQQ () mail ! gmail ! com
[Download RAW message or body]

I started a MR for a "Services" based on the firewalld xml that the user
will use to create the rules, on "easy mode".
but I can't wait for this to merge so I'd ask this to be a future adition.


On Mon, Jan 25, 2021 at 7:07 PM Tomaz Canabrava <tcanabrava@kde.org> wrote:

> Kevin,
>
> Yes, this inherited the base code from nx-firewall.
> I'll see how easy is to implement this on the current codebase without
> missing deadline for plasma 21.
>
> Tomaz
>
>
> On Fri, Jan 22, 2021 at 11:54 PM Kevin Kofler <kevin.kofler@chello.at>
> wrote:
>
>> Tomaz Canabrava wrote:
>> > Please review the code and test.
>>
>> Unfortunately, this appears to have inherited the usability issues from
>> nx-firewall:
>> https://invent.kde.org/network/plasma-firewall/-/issues/14
>> https://invent.kde.org/network/plasma-firewall/-/issues/15
>> and a new one comes up with the added support for firewalld:
>> https://invent.kde.org/network/plasma-firewall/-/issues/16
>>
>> IMHO, support for application profiles (#14) is essential for a usable
>> firewall UI. (IMHO, it is the absolute minimum. For firewalld, you also
>> need
>> to handle the concept of zones sooner or later, see #16.)
>>
>> A simpler way to create simple rules (only setting the incoming port,
>> without needing the advanced settings) (#15) would also be helpful,
>> though
>> you may be able to get away without it if you address #14.
>>
>>         Kevin Kofler
>>
>

[Attachment #3 (text/html)]

<div dir="ltr">I started a MR for a &quot;Services&quot; based on the firewalld xml \
that the user will use to create the rules, on &quot;easy mode&quot;.<div>but I \
can&#39;t wait for this to merge so I&#39;d ask this to be a future \
adition.</div><div>  </div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Mon, Jan 25, 2021 at 7:07 PM Tomaz Canabrava &lt;<a \
href="mailto:tcanabrava@kde.org">tcanabrava@kde.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr">Kevin,<div><br></div><div>Yes, this inherited the base code from \
nx-firewall.</div><div>I&#39;ll see how easy is to implement this on the current \
codebase without missing deadline for plasma \
21.</div><div><br></div><div>Tomaz</div><div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 22, 2021 at 11:54 \
PM Kevin Kofler &lt;<a href="mailto:kevin.kofler@chello.at" \
target="_blank">kevin.kofler@chello.at</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Tomaz Canabrava wrote:<br> &gt; Please review the \
code and test.<br> <br>
Unfortunately, this appears to have inherited the usability issues from<br>
nx-firewall:<br>
<a href="https://invent.kde.org/network/plasma-firewall/-/issues/14" rel="noreferrer" \
target="_blank">https://invent.kde.org/network/plasma-firewall/-/issues/14</a><br> <a \
href="https://invent.kde.org/network/plasma-firewall/-/issues/15" rel="noreferrer" \
target="_blank">https://invent.kde.org/network/plasma-firewall/-/issues/15</a><br> \
and a new one comes up with the added support for firewalld:<br> <a \
href="https://invent.kde.org/network/plasma-firewall/-/issues/16" rel="noreferrer" \
target="_blank">https://invent.kde.org/network/plasma-firewall/-/issues/16</a><br> \
<br> IMHO, support for application profiles (#14) is essential for a usable <br>
firewall UI. (IMHO, it is the absolute minimum. For firewalld, you also need <br>
to handle the concept of zones sooner or later, see #16.)<br>
<br>
A simpler way to create simple rules (only setting the incoming port, <br>
without needing the advanced settings) (#15) would also be helpful, though <br>
you may be able to get away without it if you address #14.<br>
<br>
            Kevin Kofler<br>
</blockquote></div>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]