[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Plasma Bigscreen in Kdereview
From:       Marco Martin <notmart () gmail ! com>
Date:       2021-01-25 10:27:11
Message-ID: CAD6_BoscM6ggmFMPNHc36KXu94UkQiBkaeFW=bizNrk+tg6AOA () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jan 24, 2021 at 10:19 PM Albert Astals Cid <aacid@kde.org> wrote:
> 
> > we just converted license headers to SPDX, the code should be in
> > fairly good shape by now
> 
> The ATTRIBUTION file on the root feels like it would need some qualification over \
> to which files it applies. 
> There's a few
> KPackage components should be specified in reverse domain notation.
> on cmake time, not sure how bad those are.

What are those that are not ok? i can only see it in kcms, which need
to have same package name as the kcm library name, so usually kcm_foo
like all those in plasma-desktop do as well

> Your cmake deps says you support Qt 5.9, but your QML imports say otherwise. Given \
> that you seem to require Plasma 5.19, I would suggest to increase your \
> cmake/KF5/Qt5 deps to that of what Plasma 5.19 requires. 
> files in ./kcms/plasma-settings-shell have i18n calls but as far as I can see not \
> included in any Message.sh

those are fixed

> files in ./shell/contents/configuration have i18n calls but as far as I can see not \
> included in any Message.sh

those are "special" and can't really be translatable, but none of
those qml files have strings anymore

-- 
Marco Martin


[prev in list] [next in list] [prev in thread] [next in thread]