From kde-core-devel Mon Oct 19 15:44:52 2020 From: Ingo =?ISO-8859-1?Q?Kl=F6cker?= Date: Mon, 19 Oct 2020 15:44:52 +0000 To: kde-core-devel Subject: Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX Message-Id: <4588381.GXAFRqVoOG () collossus ! localdomain> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=160312232510692 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart1780821.tdWV9SEqCh" --nextPart1780821.tdWV9SEqCh Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Montag, 19. Oktober 2020 17:22:22 CEST Milian Wolff wrote: > On Montag, 19. Oktober 2020 17:21:28 CEST Harald Sitter wrote: > > I'm not sure it's a good idea, but we could treat this like > > KDE_INSTALL_USE_QT_SYS_PATHS. By default we'll simply install to > > $CMAKE_PREFIX/share/polkit-1/actions/ unless explicitly configured with > > KDE_INSTALL_USE_POLKIT_PATHS in which case we'll use whatever polkit uses. > > What sets this apart from qt_syspath of course is that not using the > > polkit path basically never makes sense as it'd be broken. So maybe the > > default state should be ON and when one is sure that polkit isn't needed > > one could turn it OFF. > > Installing something that's never going to be used - why? I would much > rather prefer making it explicit by saying: > > Either you install it to the correct path, or you don't install it at all. FWIW, for a very similar problem (udev rules instead of polkit rules) bluez-qt has the CMAKE flag INSTALL_UDEV_RULE to disable installation of udev rules. If have this in my .kdesrc-buildrc: ===== options bluez-qt cmake-options -DINSTALL_UDEV_RULE=0 end options ===== So, maybe add a KDE_INSTALL_POLKIT_RULE[S] (or ..._ACTION[S]) flag to allow disabling the installation of polkit stuff. Regards, Ingo --nextPart1780821.tdWV9SEqCh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRxKgkQMhrHYtSAVAgadH5FMOC52AUCX420dAAKCRAadH5FMOC5 2GiOAKDjYHUqFcwB6uDocaLSiIM8ui8NXwCgtHF1qN9Bil5dGHCdN2hh5SYyT7I= =h8O9 -----END PGP SIGNATURE----- --nextPart1780821.tdWV9SEqCh--