[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: MauiKit and Index review
From: Camilo Higuita Rodriguez <chiguitar () unal ! edu ! co>
Date: 2020-09-29 19:05:23
Message-ID: CAD5sFd_inuweS+stj-VwErwH=V6raJXrPVGOVYkMazzbF4C0+Q () mail ! gmail ! com
[Download RAW message or body]
I will make the corrections to mauikit. Not sire how is the translation
catalog set?
What is the best way to set the date format to not force it?
Thanks for the feedback.
On Mon, 28 Sep 2020 at 5:42 PM Albert Astals Cid <aacid@kde.org> wrote:
> El dimarts, 22 de setembre de 2020, a les 23:05:10 CEST, Camilo Higuita
> Rodriguez va escriure:
>
> > Hi,
>
> > For the next stable release, we would like to go through KDE review
> first.
>
> >
>
> > To start I want to submit MauiKit and Index for review, and later on the
>
> > other apps.
>
> > https://invent.kde.org/maui/mauikit
>
> > https://invent.kde.org/maui/index
>
> >
>
> > The changes we have made to get to this review are all in the development
>
> > branch.
>
> >
>
> > I will be available to perform any needed fixes and answer any questions
>
> > since I'm the main developer and maintainer.
>
>
>
> mauikit
>
>
>
> ./src/controls/private/AboutDialog.qml:151:
> label1.text: "Powered by"
>
> ./src/controls/FileBrowser.qml:164: title: "Removing
> %1 files".arg(urls.length)
>
> ./src/controls/FileBrowser.qml:119: placeholderText:
> String("Filter %1 files").arg(control.currentFMList ?
> control.currentFMList.count : 0)
>
> needs i18n?
>
>
>
> ./src/controls/Dialog.qml:214: text: qsTr("Cancel")
>
> ./src/controls/Dialog.qml:259: text: qsTr("Accept")
>
> should be i18n instead of qsTr?
>
>
>
> ./src/controls/ListBrowserDelegate.qml:98: label4.text:
> model.modified ? Maui.FM.formatDate(model.modified, "MM/dd/yyyy") : ""
>
> Forcing the date format seems quite bad
>
>
>
>
>
> You don't have a Messages.sh in mauikit. If this is a library, shouldn't
> it be using i18nd instead of i18n? How is the translation catalog loaded
> otherwise?
>
>
>
>
>
> index-fm
>
> You have a Messages.sh but the translation catalog is not set anywhere
> that i can see?
>
>
>
> Cheers,
>
> Albert
>
>
>
>
>
> >
>
> > Greetings,
>
> > Camilo Higuita
>
> >
>
> >
>
>
>
>
>
>
>
>
>
>
--
*Aviso legal:* El contenido de este mensaje y los archivos adjuntos son
confidenciales y de uso exclusivo de la Universidad Nacional de Colombia.
Se encuentran dirigidos sólo para el uso del destinatario al cual van
enviados. La reproducción, lectura y/o copia se encuentran prohibidas a
cualquier persona diferente a este y puede ser ilegal. Si usted lo ha
recibido por error, infórmenos y elimínelo de su correo. Los Datos
Personales serán tratados conforme a la Ley 1581 de 2012 y a nuestra
Política de Datos Personales que podrá consultar en la página web
www.unal.edu.co <http://www.unal.edu.co/>.* *Las opiniones, informaciones,
conclusiones y cualquier otro tipo de dato contenido en este correo
electrónico, no relacionados con la actividad de la Universidad Nacional de
Colombia, se entenderá como personales y de ninguna manera son avaladas por
la Universidad.
[Attachment #3 (text/html)]
<div dir="auto">I will make the corrections to mauikit. Not sire how is the \
translation catalog set?</div><div dir="auto">What is the best way to set the date \
format to not force it?</div><div dir="auto"><br></div><div dir="auto">Thanks for the \
feedback.</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Mon, 28 Sep 2020 at 5:42 PM Albert Astals Cid <<a \
href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">El \
dimarts, 22 de setembre de 2020, a les 23:05:10 CEST, Camilo Higuita Rodriguez va \
escriure:<br><br>> Hi,<br><br>> For the next stable release, we would like to \
go through KDE review first.<br><br>> <br><br>> To start I want to submit \
MauiKit and Index for review, and later on the<br><br>> other apps.<br><br>> <a \
href="https://invent.kde.org/maui/mauikit" rel="noreferrer" \
target="_blank">https://invent.kde.org/maui/mauikit</a><br><br>> <a \
href="https://invent.kde.org/maui/index" rel="noreferrer" \
target="_blank">https://invent.kde.org/maui/index</a><br><br>> <br><br>> The \
changes we have made to get to this review are all in the development<br><br>> \
branch.<br><br>> <br><br>> I will be available to perform any needed fixes and \
answer any questions<br><br>> since I'm the main developer and \
maintainer.<br><br><br><br>mauikit<br><br><br><br>./src/controls/private/AboutDialog.qml:151: \
label1.text: "Powered by"<br><br>./src/controls/FileBrowser.qml:164: \
title: "Removing %1 \
files".arg(urls.length)<br><br>./src/controls/FileBrowser.qml:119: \
placeholderText: String("Filter %1 files").arg(control.currentFMList ? \
control.currentFMList.count : 0)<br><br> needs \
i18n?<br><br><br><br>./src/controls/Dialog.qml:214: text: \
qsTr("Cancel")<br><br>./src/controls/Dialog.qml:259: \
text: qsTr("Accept")<br><br> should be i18n instead of \
qsTr?<br><br><br><br>./src/controls/ListBrowserDelegate.qml:98: \
label4.text: model.modified ? Maui.FM.formatDate(model.modified, \
"MM/dd/yyyy") : "" <br><br> Forcing the date format \
seems quite bad<br><br><br><br><br><br>You don't have a Messages.sh in mauikit. \
If this is a library, shouldn't it be using i18nd instead of i18n? How is the \
translation catalog loaded otherwise?<br><br><br><br><br><br>index-fm<br><br>You have \
a Messages.sh but the translation catalog is not set anywhere that i can \
see?<br><br><br><br>Cheers,<br><br> Albert<br><br><br><br><br><br>> <br><br>> \
Greetings,<br><br>> Camilo Higuita<br><br>> <br><br>> \
<br><br><br><br><br><br><br><br><br><br></blockquote></div></div>
<br>
<b style="color:rgb(34,34,34);font-family:Calibri,sans-serif;font-size:14.6667px;font- \
style:normal;letter-spacing:normal;text-align:justify;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)"><span \
style="font-size:6.5pt;line-height:9.96667px;font-family:"Ancizar \
Sans",sans-serif;color:black">Aviso legal:</span></b><span \
style="font-style:normal;font-weight:400;letter-spacing:normal;text-align:justify;text \
-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);font-size:6.5pt;line-height:9.96667px;font-family:"Ancizar \
Sans",sans-serif;color:black"> El contenido de este mensaje y los archivos \
adjuntos son confidenciales y de uso exclusivo de la Universidad Nacional de \
Colombia. Se encuentran dirigidos sólo para el uso del destinatario al cual van \
enviados. La reproducción, lectura y/o copia se encuentran prohibidas a cualquier \
persona diferente a este y puede ser ilegal. Si usted lo ha recibido por error, \
infórmenos y elimínelo de su correo. Los Datos Personales serán tratados conforme \
a la Ley 1581 de 2012 y a nuestra Política de Datos Personales que podrá consultar \
en la página web </span><span \
style="color:rgb(34,34,34);font-family:Calibri,sans-serif;font-style:normal;font-weigh \
t:400;letter-spacing:normal;text-align:justify;text-indent:0px;text-transform:none;whi \
te-space:normal;word-spacing:0px;background-color:rgb(255,255,255);font-size:6.5pt;line-height:9.96667px"><a \
href="http://www.unal.edu.co/" style="color:blue" target="_blank"><span \
style="font-family:"Ancizar \
Sans",sans-serif">www.unal.edu.co</span></a></span><span \
style="font-style:normal;font-weight:400;letter-spacing:normal;text-align:justify;text \
-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);font-size:6.5pt;line-height:9.96667px;font-family:"Ancizar \
Sans",sans-serif;color:black">.<u><span> </span></u>Las opiniones, \
informaciones, conclusiones y cualquier otro tipo de dato contenido en este correo \
electrónico, no relacionados con la actividad de la Universidad Nacional de \
Colombia, se entenderá como personales y de ninguna manera son avaladas por la \
Universidad.</span><br><span \
style="color:rgb(245,132,111);font-family:ClearSans-Regular,Arial,Verdana,Helvetica,sa \
ns-serif;font-size:14px;font-style:normal;font-weight:400;letter-spacing:normal;text-a \
lign:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;back \
ground-color:rgb(255,255,255);display:inline!important;float:none"><span></span></span><span \
style="color:rgb(245,132,111);font-family:ClearSans-Regular,Arial,Verdana,Helvetica,sa \
ns-serif;font-size:14px;font-style:normal;font-weight:400;letter-spacing:normal;text-a \
lign:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;back \
ground-color:rgb(255,255,255);display:inline!important;float:none"><span></span></span>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic