[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Move Koko to KDEReview
From:       Adriaan de Groot <groot () kde ! org>
Date:       2020-06-15 9:05:03
Message-ID: 3053451.bT80LyP3VS () beastie ! bionicmutton ! org
[Download RAW message or body]


On Friday, 12 June 2020 18:05:36 CEST Carl Schwan wrote:
> > I'm kind of unsure how i feel about it downloading things on cmake time.
> 
> I asked a few packagers I know and for them, since the packagers can
> download the files and put them into the tarball, it should be fine. But
> they also said that it would be way better to have it fetched as run time

There's a couple of angles here:
- if your CMakeLists.txt tries to download something, it will fail.
- if you expect packagers to download additional files then put that in GIANT 
LETTERS in several places; also make any attempted download fail gracefully 
with a useful message ("additional source files are needed ..").

It's not that unusual for a single package to require multiple source tarballs 
or additional source files, but you need to support it *and* be clear about 
what's needed.

Koko does the right thing in accepting an already-downloaded file; it'd be 
nice to fail more gracefully, and you should make it more prominent rather 
than hidden on line 106 of CMakeLists.txt in a subdirectory.

[ade]
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]