[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Move Koko to KDEReview
From:       Carl Schwan <carl () carlschwan ! eu>
Date:       2020-06-10 13:49:09
Message-ID: FjDQSu9reJw75bycqsndwdHyHat40zEfDH_7HVKVyEi-IOXhB5urIXnJt5RRro0WaRMghmcTPzCPOD67mTX9nj0OpV7jeb8RA3ODqlOwA-0= () carlschwan ! eu
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Le mercredi, juin 10, 2020 9:01 AM, Yuri Chornoivan <yurchor@ukr.net> a =C3=
=A9crit=C2=A0:

> =


> =


> 10 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2020, 11:35:37, =D0=B2=D1=96=D0=B4=
 "Carl Schwan"carl@carlschwan.eu:
> =


> > Hi,
> > I would like to move Koko, a convergent image viewer, to KDEReview.
> > Koko is already shipped in the base Plasma mobile image and I was
> > surprised that it was still in playground. The current devs are mostly
> > Nicolas, Marco and me.
> > Koko is following the KDE HIG and is build using QtQuick and the
> > Kirigami framework.
> > The repo is located here: https://invent.kde.org/plasma-mobile/koko/.
> > There is only one know big issue, but it is in the progress of
> > being resolved1.
> > In the future, I plan to add a simple image editor that is currently
> > being developed as a separate and reusable library. More info about
> > it is available in my latest blog post2.
> > I would be happy if it could be reviewed and my goal is to move it to
> > the release service, I hope in time for 20.08.
> > From the release sanity checklist:
> > =


> > -   licensing should be ok (LGPL-2.1-only or LGPL-3.0-only or
> >     LicenseRef-KDE-Accepted-LGPL), but some headers are missing in the
> >     CMake files :/
> >     =


> > -   A Messages.sh file is missing and help would be welcome to figure
> >     out if Koko need one since translations are regularly being pushed=
 by
> >     scripty.
> >     =


> =


> Added. Scripty will extract the catalog for translation tomorrow.
> =


> But I bet the translations will not be loaded because of the lack of KAb=
outData and friends. See KLook:
> =


> https://invent.kde.org/graphics/klook/-/blob/master/src/main.cpp
> =


> Hope this helps and thanks for your work.
> =


> Best regards,
> Yuri

Thanks for the Messages.sh commit, I now created a merge request
adding the KAboutData bits: https://invent.kde.org/plasma-mobile/koko/-/me=
rge_requests/25

> =


> > -   Screenshot is missing but I plan to add one before the release.
> > -   CI works and there is a .gitlab-ci.yml file.
> > -   There is an AppStream file.
> > -   There is some documentation on userbase: https://userbase.kde.org/=
Koko
> >     I plan to also update it before the next release.
> >     =


> > =


> > Carl Schwan
> > https://carlschwan.eu


["publickey - carl@carlschwan.eu - 0x7F564CB5.asc" (application/pgp-keys)]
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]