From kde-core-devel Mon Dec 30 16:56:00 2019 From: Dominik Haumann Date: Mon, 30 Dec 2019 16:56:00 +0000 To: kde-core-devel Subject: Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submit Message-Id: X-MARC-Message: https://marc.info/?l=kde-core-devel&m=157772500726605 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--000000000000b68e90059aeeb89e" --000000000000b68e90059aeeb89e Content-Type: text/plain; charset="UTF-8" Hi Steve, Stephen Kelly schrieb am Mo., 30. Dez. 2019, 11:57: > > On 30/12/2019 10:55, Christoph Cullmann wrote: > > Hi, > > > >>> With my KTextEditor hat on: KF6:TextDocument implies somehow a link > >>> to QTextDocument or KF6:TextEditor, which both is incorrect, right? > >> > >> QTextDocument is exactly what it's about, which makes the name > >> KF6::TextDocument fully appropriate and correct. > >> > >>> Before starting this work, let's clarify whether we can find a more > >>> unique name (like KF6:GrantleeTextDocument). > >> > >> The name I suggest is already correct. > >> > >>> Since I haven't used Grantlee yet, I sm likely not the best person > >>> to find a better name ;) > >> > >> Remember, Grantlee is a set of Frameworks (*Just like KF5/6*) which > >> happens to contain just TWO independent libraries. > > > > Hmm, I am not that sure about that naming. > > > Let's discuss it in the future (when KF6 is open) when everyone > participating in the discussion can know what is being discussed. > Fine with me. Let me add that I'm also very much in favor of adding Grantlee to the KDE Frameworks group, I'm just nitpicking :-) PS: a KF6 task on the phabricator KF6 board to save the current state of the discussion makes a lot of sense ;) Best regards Dominik > --000000000000b68e90059aeeb89e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Steve,

Stephen Kelly <steveire@gmail.com> schrieb am Mo., 30. Dez. 2019, 11:57:=

On 30/12/2019 10:55, Christoph Cullmann wrote:
> Hi,
>
>>> With my KTextEditor hat on: KF6:TextDocument implies somehow a= link
>>> to QTextDocument or KF6:TextEditor, which both is incorrect, r= ight?
>>
>> QTextDocument is exactly what it's about, which makes the name=
>> KF6::TextDocument fully appropriate and correct.
>>
>>> Before starting this work, let's clarify whether we can fi= nd a more
>>> unique name (like KF6:GrantleeTextDocument).
>>
>> The name I suggest is already correct.
>>
>>> Since I haven't used Grantlee yet, I sm likely not the bes= t person
>>> to find a better name ;)
>>
>> Remember, Grantlee is a set of Frameworks (*Just like KF5/6*) whic= h
>> happens to contain just TWO independent libraries.
>
> Hmm, I am not that sure about that naming.


Let's discuss it in the future (when KF6 is open) when everyone
participating in the discussion can know what is being discussed.

Fine with = me. Let me add that I'm also very much in favor of adding Grantlee to t= he KDE Frameworks group, I'm just nitpicking :-)

PS: a KF6 task on the phabricator KF6 board to= save the current state of the discussion makes a lot of sense ;)

Best regards
Dominik
--000000000000b68e90059aeeb89e--