[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Kdiff3 in kdereview
From:       Michael Reeves <reeves.87 () gmail ! com>
Date:       2019-01-16 14:15:29
Message-ID: CANp6eRnqC9EtWWhjib_Sxf8Sk=b88xTYTOJk7BoFOMby-5zNgQ () mail ! gmail ! com
[Download RAW message or body]

Would there be any objections to moving Kdiff3 to extragear. I looking to
do a test release by the end of Feb.

On Nov 14, 2018 10:30 AM, "Michael Reeves" <reeves.87@gmail.com> wrote:

Its been two months now has any found problems that must be resolved. I am
currently working my through the code tring to update it with a more
modular approach. At present it is nightmare trying sort through the code a
decipher what going on much less change anything. The current approach uses
the class keyword but doesn't isolate class from eachother either in terms
of the file they are in or member variable access. All classes are
switching to accessore funtion and private member data as a first step in
cleanup. In FileAccess the code is now much cleaner and relies on QT/KIO
for most of the work. QDir::setCurrent calls have been removed as they
introduced an unnecessary point of failure.


On Sat, Sep 15, 2018, 12:16 PM Michael Reeves <reeves.87@gmail.com wrote:

> Yes I am going to setup a vm and see if this works. My system is having
> trouble with this.
>
> On Sat, Sep 15, 2018, 10:30 AM Wolfgang Bauer <wbauer@tmo.at> wrote:
>
>> Am Freitag, 14. September 2018, 16:36:10 schrieb Michael Reeves:
>> > Can some do a clean install and see if right clicking on a file brings
>> up
>> > the kdiff3 context menu?
>>
>> You mean right-clicking on a file in dolphin?
>>
>>
>> Seems to work fine here with latest git master, the kdiff3 menu does show
>> up,
>> and seems to work as expected.
>>
>> That's openSUSE 42.3 with latest KF5 and Qt5 (not a clean install though).
>>
>> Kind Regards,
>> Wolfgang
>>
>>

[Attachment #3 (text/html)]

<div dir="auto">Would there be any objections to moving Kdiff3 to extragear. I \
looking to do a test release by the end of Feb.</div><div \
class="gmail_extra"><br><div class="gmail_quote">On Nov 14, 2018 10:30 AM, \
&quot;Michael Reeves&quot; &lt;<a \
href="mailto:reeves.87@gmail.com">reeves.87@gmail.com</a>&gt; wrote:<br \
type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div dir="auto"><div>Its been two months now has any \
found problems that must be resolved. I am currently working my through the code \
tring to update it with a more modular approach. At present it is nightmare trying \
sort through the code a decipher what going on much less change anything. The current \
approach uses the class keyword but doesn&#39;t isolate class from eachother either \
in terms of the file they are in or member variable access. All classes are switching \
to accessore funtion and private member data as a first step in cleanup. In \
FileAccess the code is now much cleaner and relies on QT/KIO for most of the work. \
QDir::setCurrent calls have been removed as they introduced an unnecessary point of \
failure.<div class="elided-text"><br><br><div class="gmail_quote"><div dir="ltr">On \
Sat, Sep 15, 2018, 12:16 PM Michael Reeves &lt;<a href="mailto:reeves.87@gmail.com" \
target="_blank" rel="noreferrer">reeves.87@gmail.com</a> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="auto"><div>Yes I am going to setup a vm and see if \
this works. My system is having trouble with this.<br><br><div \
class="gmail_quote"><div dir="ltr">On Sat, Sep 15, 2018, 10:30 AM Wolfgang Bauer \
&lt;<a href="mailto:wbauer@tmo.at" rel="noreferrer noreferrer" \
target="_blank">wbauer@tmo.at</a>&gt; wrote:<br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Am Freitag, 14. \
September 2018, 16:36:10 schrieb Michael Reeves:<br> &gt; Can some do a clean install \
and see if right clicking on a file brings up<br> &gt; the kdiff3 context menu?<br>
<br>
You mean right-clicking on a file in dolphin?<br>
<br><br>
Seems to work fine here with latest git master, the kdiff3 menu does show up, <br>
and seems to work as expected.<br>
<br>
That&#39;s openSUSE 42.3 with latest KF5 and Qt5 (not a clean install though).<br>
<br>
Kind Regards,<br>
Wolfgang<br>
<br>
</blockquote></div></div></div>
</blockquote></div></div></div></div>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]