[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 101343: remove functions *Command::name() which are not used
From: Alexander Potashev <aspotashev () gmail ! com>
Date: 2018-12-24 9:03:56
Message-ID: 20181224090356.19757.34580 () mimi ! kde ! org
[Download RAW message or body]
--===============2665838773841205974==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/101343/
-----------------------------------------------------------
(Updated Dec. 24, 2018, 12:03 p.m.)
Status
------
This change has been discarded.
Review request for KDE Base Apps and David Faure.
Repository: kde-baseapps
Description
-------
konq-plugins/domtreeviewer builds without there functions.
May be these functions were left for future integration of domtreeviewer undoable \
commands' into Konqueror's undo stack. But for now, they only add a few translatable \
strings the user won't ever see.
Diffs
-----
konq-plugins/domtreeviewer/domtreecommands.h df8272e
konq-plugins/domtreeviewer/domtreecommands.cpp e4c7fff
Diff: https://git.reviewboard.kde.org/r/101343/diff/1/
Testing
-------
konq-plugins/domtreeviewer compiles after this change.
Thanks,
Alexander Potashev
--===============2665838773841205974==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/101343/">https://git.reviewboard.kde.org/r/101343/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><em>Updated Dec. 24, 2018, 12:03 p.m.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">konq-plugins/domtreeviewer builds without there functions.
May be these functions were left for future integration of domtreeviewer undoable \
commands' into Konqueror's undo stack. But for now, they only add a few \
translatable strings the user won't ever see.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">konq-plugins/domtreeviewer compiles after this change.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konq-plugins/domtreeviewer/domtreecommands.h <span style="color: \
grey">(df8272e)</span></li>
<li>konq-plugins/domtreeviewer/domtreecommands.cpp <span style="color: \
grey">(e4c7fff)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/101343/diff/1/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2665838773841205974==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic