[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows
From: Ralf Habacker <ralf.habacker () freenet ! de>
Date: 2017-12-27 10:46:08
Message-ID: 20171227104608.26523.61660 () mimi ! kde ! org
[Download RAW message or body]
--===============8286604980211663290==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130239/
-----------------------------------------------------------
(Updated Dec. 27, 2017, 10:46 a.m.)
Status
------
This change has been marked as submitted.
Review request for kdelibs and Albert Astals Cid.
Changes
-------
Submitted with commit 246298e57ed7ff7a3cbabe5fc9f95957cb6dc257 by Ralf Habacker to \
branch KDE/4.14.
Bugs: 384334
http://bugs.kde.org/show_bug.cgi?id=384334
Repository: kdelibs
Description
-------
This patch fixes an issue that on the first start of KMyMoney (and on some computers \
on every start for example reported by \
https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9) \
on running kconf_update the user account control pops up and forces the user to allow \
or deny this application.
Commit message
Add Windows manifest to kconf_update.exe
This explicitly sets the execution level to 'asInvoker', preventing
Windows' UAC heuristics from deciding that because its name mentions
"update", it probably needs to escalate privileges.
FIXED-IN:4.14.36
BUG:384334
Diffs
-----
kconf_update/CMakeLists.txt 6bf3bf1f923baf11aad63e10fe249d70ce1b4d33
Diff: https://git.reviewboard.kde.org/r/130239/diff/3/
Testing
-------
Compiled at https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4 \
and tested with KMyMoney snapshot for Windows downloadable from \
https://software.opensuse.org/package/mingw32-kmymoney-portable
Thanks,
Ralf Habacker
--===============8286604980211663290==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130239/">https://git.reviewboard.kde.org/r/130239/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdelibs and Albert Astals Cid.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><em>Updated Dec. 27, 2017, 10:46 a.m.</em></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 246298e57ed7ff7a3cbabe5fc9f95957cb6dc257 by Ralf \
Habacker to branch KDE/4.14.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a href="http://bugs.kde.org/show_bug.cgi?id=384334">384334</a>
</div>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch fixes an issue that on the first start of \
KMyMoney (and on some computers on every start for example reported by \
https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9) \
on running kconf_update the user account control pops up and forces the user to allow \
or deny this application.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Commit message</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add \
Windows manifest to kconf_update.exe</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>This \
explicitly sets the execution level to 'asInvoker', preventing Windows' \
UAC heuristics from deciding that because its name mentions "update", it \
probably needs to escalate privileges.
FIXED-IN:4.14.36
BUG:384334
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled at \
https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4 and \
tested with KMyMoney snapshot for Windows downloadable from \
https://software.opensuse.org/package/mingw32-kmymoney-portable</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kconf_update/CMakeLists.txt <span style="color: \
grey">(6bf3bf1f923baf11aad63e10fe249d70ce1b4d33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130239/diff/3/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8286604980211663290==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic