[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 128854: Add a Tools button above the process list of System Monitor
From: Kevin Funk <kfunk () kde ! org>
Date: 2017-08-03 12:27:45
Message-ID: 20170803122745.5572.26002 () mimi ! kde ! org
[Download RAW message or body]
--===============1329287775291033934==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote:
> > processui/ksysguardprocesslist.cpp, line 354
> > <https://git.reviewboard.kde.org/r/128854/diff/3/?file=498252#file498252line354>
> >
> > Why this?
>
> Gregor Mi wrote:
> When I try to capture "d", then I get the following compiler error:
>
> processui/ksysguardprocesslist.cpp:355:36: error: capture of non-variable \
> ‘KSysGuardProcessList::d'
> I also find the current solution a bit strange. See here: \
> https://stackoverflow.com/questions/12944002/capture-by-value-class-members (C++14 \
> might solve the issue)
Just capture `[this]`. `d` is visible then.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128854/#review103512
-----------------------------------------------------------
On Aug. 3, 2017, 11:08 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128854/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 11:08 a.m.)
>
>
> Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, \
> Thomas Lübking, and Thomas Pfeiffer.
>
> Repository: libksysguard
>
>
> Description
> -------
>
> This adds a new "Tools" button to the ksysguard widget which contains entries to \
> related tools:
> - Run Command --> starts KRunner to execute a command
> - KSysguard --> starts KSysguard (this is useful because Ctrl+Esc only starts the \
> lightweight System Monitor which has less features)
> - Info Center --> starts the Info Center which shows additional system information
> - Htop --> starts htop
> - Kill a window (Ctrl+Alt+Esc) --> triggers the KWin kill window function. The \
> displayed shortcut is the one set in Global Keyboard Shortcuts. Currently, this \
> shortcut is shown in the End Process... button tooltip but there it is hard-coded.
> This RR replaces this old RR https://git.reviewboard.kde.org/r/122249/
>
>
> Diffs
> -----
>
> CMakeLists.txt 84a447990563cf1605c06989b255627e99ef31b3
> processui/CMakeLists.txt 1927839282a6282c824f5bbb5d35ea94075f428e
> processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3
> processui/ksysguardprocesslist.cpp 79e9bb3c4e9d481a03d2e5992ab1c0692a06de28
>
> Diff: https://git.reviewboard.kde.org/r/128854/diff/
>
>
> Testing
> -------
>
> - test if all tools start correctly
> - check if a changed shortcut for Kill Window is shown in the tools menu (see \
> screenshot)
> - check if for example htop is not installed that there is no menu item for it
>
>
> File Attachments
> ----------------
>
> screenshot of the new Tools button
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
>
>
> Thanks,
>
> Gregor Mi
>
>
--===============1329287775291033934==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128854/">https://git.reviewboard.kde.org/r/128854/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 31st, 2017, 9:11 a.m. UTC, <b>Kevin \
Funk</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128854/diff/3/?file=498252#file498252line354" \
style="color: black; font-weight: bold; text-decoration: \
underline;">processui/ksysguardprocesslist.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">354</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">auto</span> <span class="n">d1</span> <span class="o">=</span> <span \
class="n">d</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
this?</p></pre> </blockquote>
<p>On August 3rd, 2017, 11:02 a.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When \
I try to capture "d", then I get the following compiler error:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">processui/ksysguardprocesslist.cpp:355:36: error: capture of non-variable \
‘KSysGuardProcessList::d' </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I also find the current solution a bit \
strange. See here: https://stackoverflow.com/questions/12944002/capture-by-value-class-members \
(C++14 might solve the issue)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Just capture <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">[this]</code>. <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">d</code> is visible then.</p></pre> <br />
<p>- Kevin</p>
<br />
<p>On August 3rd, 2017, 11:08 a.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps, Martin Flöser, John Tapsell, Ken Vermette, \
Thomas Lübking, and Thomas Pfeiffer.</div> <div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2017, 11:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a new "Tools" button to the ksysguard widget \
which contains entries to related tools:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Run Command --> starts KRunner to execute a command</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">KSysguard --> starts KSysguard (this is useful because Ctrl+Esc only \
starts the lightweight System Monitor which has less features)</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Info Center --> starts the Info Center which shows additional system \
information</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Htop --> starts htop</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Kill a \
window (Ctrl+Alt+Esc) --> triggers the KWin kill window function. The displayed \
shortcut is the one set in Global Keyboard Shortcuts. Currently, this shortcut is \
shown in the End Process... button tooltip but there it is hard-coded.</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This RR replaces this old RR \
https://git.reviewboard.kde.org/r/122249/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">test if all tools start \
correctly</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">check if a changed shortcut for Kill Window is shown in \
the tools menu (see screenshot)</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">check if for example \
htop is not installed that there is no menu item for it</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(84a447990563cf1605c06989b255627e99ef31b3)</span></li>
<li>processui/CMakeLists.txt <span style="color: \
grey">(1927839282a6282c824f5bbb5d35ea94075f428e)</span></li>
<li>processui/ProcessWidgetUI.ui <span style="color: \
grey">(e50f55cf1813b00d49b1716023df487ffbd536e3)</span></li>
<li>processui/ksysguardprocesslist.cpp <span style="color: \
grey">(79e9bb3c4e9d481a03d2e5992ab1c0692a06de28)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128854/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png">screenshot \
of the new Tools button</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1329287775291033934==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic